[IMP][14.0] shopfloor delivery: Better messages #972
Conversation
mmequignon
force-pushed
the
14.0-shopfloor_delivery_handle_return
branch
from
a3738f3 to
a54680a
Compare
mmequignon
force-pushed
the
14.0-shopfloor_delivery_handle_return
branch
from
fb9cced to
7bdedd1
Compare
| message = self._check_picking_status(pickings, states=states) | ||
| if message: | ||
| return message | ||
| message = self._check_picking_type(pickings) | ||
| if message: | ||
| return message |
There was a problem hiding this comment.
You should first check the picking type and then call _check_picking_status on the pickings with the right picking type.
Maybe _check_picking_type can return the list of filtered pickings and raise error if that list is empty.
Then call _check_picking_status on that result.
This is to ensure that you check the status on the pickings to process and not on a picking with a wrong picking type.
There was a problem hiding this comment.
And extract if not pickings.exists() from _check_picking_status as it's not a status. This should be the first test. Then test picking type. And then test picking status.
There was a problem hiding this comment.
And extract if not pickings.exists() from _check_picking_status as it's not a status. This should be the first test. Then test picking type. And then test picking status.
|
closed in favor of closed in favor of #987 |
Now that return moves are possibly being created when a picking is unreleased, display a nice message to the user when trying to process a product that should be returned in stock.
Based on #971