[14.0] shopfloor checkout: Better messages #983
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @TDu, @simahawk, @guewen, @JuMiSanAr, @sebalix, |
jbaudoux
reviewed
Feb 18, 2025
| @@ -952,3 +983,13 @@ def lot_change_no_line_found(self): | |||
| "message_type": "error", | |||
| "body": _("Unable to find a line with the same product but different lot."), | |||
| } | |||
|
|
|||
| def picking_type_is_return(self, picking): | |||
There was a problem hiding this comment.
The fact that it is a return is a specific use case. Make the method name more generic.
Suggested change
| def picking_type_is_return(self, picking): | |
| def reserved_for_other_picking_type(self, picking): |
|
closed in favor of #987 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #972
Only review shopfloor_checkout commits here, thanks <3