Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] - shopfloor_packing #718

Open
wants to merge 15 commits into
base: 16.0
Choose a base branch
from

Conversation

sbejaoui
Copy link
Contributor

No description provided.

@sbejaoui sbejaoui force-pushed the 16.0-shopfloor_packing-sbj branch 6 times, most recently from 4ab2c1b to 57d45d5 Compare August 14, 2023 10:32
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 28, 2024
@lmignon lmignon force-pushed the 16.0-shopfloor_packing-sbj branch from 9c8edba to a2feed3 Compare May 10, 2024 12:43
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 12, 2024
@sbejaoui sbejaoui force-pushed the 16.0-shopfloor_packing-sbj branch from 9b58723 to 34946ea Compare June 27, 2024 13:28
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 27, 2024
@github-actions github-actions bot closed this Dec 1, 2024
@jbaudoux jbaudoux added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Dec 23, 2024
@jbaudoux jbaudoux reopened this Dec 23, 2024
@rousseldenis rousseldenis added this to the 16.0 milestone Jan 21, 2025
@rousseldenis rousseldenis force-pushed the 16.0-shopfloor_packing-sbj branch from 2a1c873 to 84cd6f8 Compare January 21, 2025 15:05
@rousseldenis
Copy link
Contributor

@jbaudoux

Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick review

Comment on lines +2 to +3
"cluster_picking.pack_picking_put_in_pack.title": "Packing: Enter the number of boxes used.",
"cluster_picking.pack_picking_put_in_pack.scan_placeholder": "Number of boxes used",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As now we choose a package type, this needs to be adapted.

Suggested change
"cluster_picking.pack_picking_put_in_pack.title": "Packing: Enter the number of boxes used.",
"cluster_picking.pack_picking_put_in_pack.scan_placeholder": "Number of boxes used",
"cluster_picking.pack_picking_put_in_pack.title": "Packing",
"cluster_picking.pack_picking_put_in_pack.scan_placeholder": "Package type",

Comment on lines +2 to +3
"cluster_picking.pack_picking_put_in_pack.title": "Emballage: Nombre de colis.",
"cluster_picking.pack_picking_put_in_pack.scan_placeholder": "Nombre de colis créés?",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@@ -0,0 +1,95 @@
# Translation of Odoo Server.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fr.po instead of fr_BE.po

@@ -0,0 +1,95 @@
# Translation of Odoo Server.
# This file contains the translation of the following modules:
# * alc_shopfloor_packing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace all or regenerate file

Suggested change
# * alc_shopfloor_packing
# * shopfloor_packing

Comment on lines 21 to 22
msgid "If set, some operations need to be packed by the shopdloor operator"
msgstr "Si coché, le contenu des bacs doit encore être mis en boîte par l'opérateur Shofloorr"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgid "If set, some operations need to be packed by the shopdloor operator"
msgstr "Si coché, le contenu des bacs doit encore être mis en boîte par l'opérateur Shofloorr"
msgid "If set, some operations need to be packed by the operator"
msgstr "Si coché, le contenu des bacs doit encore être mis en boîte par l'opérateur"

@rousseldenis rousseldenis force-pushed the 16.0-shopfloor_packing-sbj branch from 84cd6f8 to 46db2a2 Compare January 22, 2025 07:40
"summary": """
Shopfloor mobile extension for packing operation into cluster picking
""",
"author": "ACSONE SA/NV,Odoo Community Association (OCA)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"author": "ACSONE SA/NV,Odoo Community Association (OCA)",
"author": "ACSONE SA/NV,BCIM,Odoo Community Association (OCA)",

"name": "Shopfloor Packing",
"version": "16.0.1.0.0",
"summary": """ Manage Packing into cluster picking""",
"author": "ACSONE SA/NV,Odoo Community Association (OCA)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"author": "ACSONE SA/NV,Odoo Community Association (OCA)",
"author": "ACSONE SA/NV,BCIM,Odoo Community Association (OCA)",

sbejaoui and others added 12 commits February 21, 2025 15:30
If a partially available product becomes completely available and the reserved
quantity increases after the "put in pack" action, a new move line will be
created with the done quantity as a copy of the line that will be packed.
The original line will keep the result package, which is the package scanned
by the operator, and the remaining quantity to do.

Since the package is an internal package, the line with the remaining quantity
to do will be proposed in the packing process and considered as picked. If the
operator don't pay attention, and confirm the packaging, both lines will be set
to done.
@rousseldenis rousseldenis force-pushed the 16.0-shopfloor_packing-sbj branch from 46db2a2 to 1686430 Compare February 21, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants