[18.0][MIG] base_maintenance: Migration to 18.0 #452
Conversation
Currently translated at 100.0% (25 of 25 strings) Translation: maintenance-14.0/maintenance-14.0-base_maintenance Translate-URL: https://translation.odoo-community.org/projects/maintenance-14-0/maintenance-14-0-base_maintenance/it/
Since the tree view is editable when accessing in the configuration menu, the new field need to be showed also in the tree view.
Currently translated at 100.0% (22 of 22 strings) Translation: maintenance-15.0/maintenance-15.0-base_maintenance Translate-URL: https://translation.odoo-community.org/projects/maintenance-15-0/maintenance-15-0-base_maintenance/pt/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-16.0/maintenance-16.0-base_maintenance Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-base_maintenance/
Currently translated at 100.0% (22 of 22 strings) Translation: maintenance-16.0/maintenance-16.0-base_maintenance Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-base_maintenance/es/
Currently translated at 100.0% (22 of 22 strings) Translation: maintenance-16.0/maintenance-16.0-base_maintenance Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-base_maintenance/pt_BR/
There was a problem hiding this comment.
LGTM
TT54649
@Tecnativa @pedrobaeza @victoralmau could you please review this.
|
/ocabot migration base_maintenance |
| @@ -4,7 +4,7 @@ | |||
| # | |||
| msgid "" | |||
| msgstr "" | |||
| "Project-Id-Version: Odoo Server 16.0\n" | |||
| "Project-Id-Version: Odoo Server 17.0\n" | |||
There was a problem hiding this comment.
Incorrect version. If edited, better to put the correct one.
| # Setup for creating user and maintenance team records for tests | ||
| cls.user = cls.env.ref("base.user_admin") | ||
|
|
||
| def test_create_maintenance_team(self): |
There was a problem hiding this comment.
This test is not adding value, as it's testing ORM features, not this module features. You can print the report as test of not crashing during its rendering, which adds value.
| </page> | ||
| </notebook> | ||
| </field> | ||
| <xpath expr="//field[@name='description']/.." position="attributes"> |
There was a problem hiding this comment.
This should be cherry-picked from e589471 before the migration commit instead of putting it here as if it was part of the migration.
There was a problem hiding this comment.
@pedrobaeza , I cherry-picked the changes and fixed the issues. Could you please review it again?
BhaveshHeliconia
force-pushed
the
18.0-mig-base_maintenance
branch
2 times, most recently
from
f41aaea to
791eba1
Compare
after this commit odoo/odoo@3bd8410 the maintenance request form view now has an independent page. This commit adapts the view to align with the new page structure.
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 1d6bf2a. Thanks a lot for contributing to OCA. ❤️ |
No description provided.