Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] maintenance_project: Migration to 18. #448

Merged
merged 38 commits into from
Feb 20, 2025

Conversation

BhaveshHeliconia
Copy link

@BhaveshHeliconia BhaveshHeliconia commented Jan 24, 2025

Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this PR as a dependency so that tests can run and Runboat can start correctly.

https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

TT54668
@Tecnativa

@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-maintenance_project branch 2 times, most recently from 05a70d7 to c2abcfc Compare February 7, 2025 10:04
Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the other PR is merged, please rebase and remove the last commit.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file. It is not related to this module; it belongs to another module.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlos-lopez-tecnativa , Thank you for the suggestions! please review. it's fixed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HeliconiaSolutions Please remove this file, its belong to the maintenance_plan module
image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlos-lopez-tecnativa, Please review. it's fixed!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but you misunderstood and deleted the wrong file.

In your last commit, you deleted this file, which is correct and should not be deleted.
image

I was referring to this file, which should be deleted:
https://github.com/HeliconiaIO/maintenance/blob/18.0-mig-maintenance_project/maintenance_plan/views/maintenance_equipment_views.xml
Please review again.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlos-lopez-tecnativa, Yes, I initially deleted it by mistake, but I later added the file. Please check.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HeliconiaSolutions I was referring to this file; it must be deleted as it belongs to the maintenance_plan module. Please let me know if I made myself clear.
https://github.com/HeliconiaIO/maintenance/blob/18.0-mig-maintenance_project/maintenance_plan/views/maintenance_equipment_views.xml

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @HeliconiaSolutions

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlos-lopez-tecnativa , Please review. it's done.

@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-maintenance_project branch 2 times, most recently from 5e3c42c to 6ccfbf1 Compare February 7, 2025 12:53
dalonsod and others added 23 commits February 7, 2025 18:24
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: maintenance-14.0/maintenance-14.0-maintenance_project
Translate-URL: https://translation.odoo-community.org/projects/maintenance-14-0/maintenance-14-0-maintenance_project/
Currently translated at 100.0% (23 of 23 strings)

Translation: maintenance-14.0/maintenance-14.0-maintenance_project
Translate-URL: https://translation.odoo-community.org/projects/maintenance-14-0/maintenance-14-0-maintenance_project/it/
Currently translated at 100.0% (23 of 23 strings)

Translation: maintenance-15.0/maintenance-15.0-maintenance_project
Translate-URL: https://translation.odoo-community.org/projects/maintenance-15-0/maintenance-15-0-maintenance_project/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: maintenance-16.0/maintenance-16.0-maintenance_project
Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_project/
Currently translated at 100.0% (21 of 21 strings)

Translation: maintenance-16.0/maintenance-16.0-maintenance_project
Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_project/it/
victoralmau and others added 10 commits February 7, 2025 18:24
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: maintenance-16.0/maintenance-16.0-maintenance_project
Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_project/
Currently translated at 100.0% (21 of 21 strings)

Translation: maintenance-16.0/maintenance-16.0-maintenance_project
Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_project/it/
Currently translated at 100.0% (21 of 21 strings)

Translation: maintenance-16.0/maintenance-16.0-maintenance_project
Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_project/it/
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-maintenance_project branch 4 times, most recently from ab08749 to 8cfd052 Compare February 13, 2025 04:24

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove this view?

I was referring to another view that belongs to a different module. This view in this module should not be deleted, please restore it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlos-lopez-tecnativa , Please review.

@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-maintenance_project branch from 8cfd052 to e18f6fc Compare February 14, 2025 08:27
Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@victoralmau @pedrobaeza Could you review this, please?

Non-blocking comment: Please squash administrative commits a bit.

@pedrobaeza
Copy link
Member

/ocabot migration maintenance_project

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Feb 19, 2025
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review OK

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-448-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6df11cf into OCA:18.0 Feb 20, 2025
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6636824. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.