-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] maintenance_project: Migration to 18. #448
[18.0][MIG] maintenance_project: Migration to 18. #448
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this PR as a dependency so that tests can run and Runboat can start correctly.
TT54668
@Tecnativa
05a70d7
to
c2abcfc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that the other PR is merged, please rebase and remove the last commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this file. It is not related to this module; it belongs to another module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carlos-lopez-tecnativa , Thank you for the suggestions! please review. it's fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carlos-lopez-tecnativa, Please review. it's fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, but you misunderstood and deleted the wrong file.
In your last commit, you deleted this file, which is correct and should not be deleted.
I was referring to this file, which should be deleted:
https://github.com/HeliconiaIO/maintenance/blob/18.0-mig-maintenance_project/maintenance_plan/views/maintenance_equipment_views.xml
Please review again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carlos-lopez-tecnativa, Yes, I initially deleted it by mistake, but I later added the file. Please check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HeliconiaSolutions I was referring to this file; it must be deleted as it belongs to the maintenance_plan module. Please let me know if I made myself clear.
https://github.com/HeliconiaIO/maintenance/blob/18.0-mig-maintenance_project/maintenance_plan/views/maintenance_equipment_views.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @HeliconiaSolutions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carlos-lopez-tecnativa , Please review. it's done.
5e3c42c
to
6ccfbf1
Compare
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-14.0/maintenance-14.0-maintenance_project Translate-URL: https://translation.odoo-community.org/projects/maintenance-14-0/maintenance-14-0-maintenance_project/
Currently translated at 100.0% (23 of 23 strings) Translation: maintenance-14.0/maintenance-14.0-maintenance_project Translate-URL: https://translation.odoo-community.org/projects/maintenance-14-0/maintenance-14-0-maintenance_project/it/
Currently translated at 100.0% (23 of 23 strings) Translation: maintenance-15.0/maintenance-15.0-maintenance_project Translate-URL: https://translation.odoo-community.org/projects/maintenance-15-0/maintenance-15-0-maintenance_project/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-16.0/maintenance-16.0-maintenance_project Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_project/
Currently translated at 100.0% (21 of 21 strings) Translation: maintenance-16.0/maintenance-16.0-maintenance_project Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_project/it/
… project/task fields TT50829
…nager" to maintenance fields TT50829
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-16.0/maintenance-16.0-maintenance_project Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_project/
…ipment manager group Related to OCA#424 TT50829
Currently translated at 100.0% (21 of 21 strings) Translation: maintenance-16.0/maintenance-16.0-maintenance_project Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_project/it/
Currently translated at 100.0% (21 of 21 strings) Translation: maintenance-16.0/maintenance-16.0-maintenance_project Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_project/it/
ab08749
to
8cfd052
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove this view?
I was referring to another view that belongs to a different module. This view in this module should not be deleted, please restore it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carlos-lopez-tecnativa , Please review.
8cfd052
to
e18f6fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@victoralmau @pedrobaeza Could you review this, please?
Non-blocking comment: Please squash administrative commits a bit.
/ocabot migration maintenance_project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and functional review OK
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 6636824. Thanks a lot for contributing to OCA. ❤️ |
Depends on