Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][IMP] maintenance_account: Create equipment description from move line name #386

Merged
merged 1 commit into from
Mar 5, 2024
Merged

[15.0][IMP] maintenance_account: Create equipment description from move line name #386

merged 1 commit into from
Mar 5, 2024

Conversation

carolinafernandez-tecnativa
Copy link

@carolinafernandez-tecnativa carolinafernandez-tecnativa commented Mar 4, 2024 •
edited
Loading

  • The first line of the name from account.move should go to the name of the equipment.
  • The rest of the lines go to the equipment description

@Tecnativa
TT47802
@pedrobaeza @victoralmau

@OCA-git-bot
Copy link
Contributor

Hi @victoralmau,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza added this to the 15.0 milestone Mar 4, 2024
pedrobaeza
pedrobaeza requested changes Mar 4, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not what you have to do.

  • The first line of the name from account.move should go to the name of the equipment.
  • The rest of the lines go to the description.

@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 15.0-imp-maintenance_account-name-invoice-line-equipment-description branch from fff42ac to ecad38f Compare March 4, 2024 17:00
@carolinafernandez-tecnativa
Copy link
Author

This is not what you have to do.

  • The first line of the name from account.move should go to the name of the equipment.
  • The rest of the lines go to the description.

Changes applied.

@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 15.0-imp-maintenance_account-name-invoice-line-equipment-description branch from ecad38f to 8619bad Compare March 4, 2024 17:29
@pedrobaeza pedrobaeza requested a review from victoralmau March 4, 2024 18:44
@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-386-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 70733e0 into OCA:15.0 Mar 5, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ee37340. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-imp-maintenance_account-name-invoice-line-equipment-description branch March 5, 2024 07:28
@carolinafernandez-tecnativa carolinafernandez-tecnativa mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victoralmau victoralmau victoralmau approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@carolinafernandez-tecnativa @OCA-git-bot @pedrobaeza @victoralmau