[16.0][IMP] maintenance_account: Create equipment description from move line name #387
Conversation
|
Hi @victoralmau, |
|
Indicate that this is a forward-port of ... Why is it draft? |
I change state when everything is fine. Now its ready for review :) |
carolinafernandez-tecnativa
force-pushed
the
16.0-imp-maintenance_account-name-invoice-line-equipment-description
branch
3 times, most recently
from
7a8bb8b to
82a9047
Compare
carolinafernandez-tecnativa
force-pushed
the
16.0-imp-maintenance_account-name-invoice-line-equipment-description
branch
from
82a9047 to
c55172f
Compare
| if "\n" in self.name: | ||
| lf_index = self.name.index("\n") | ||
| equipment_name = self.name[:lf_index] | ||
| description = html_escape(self.name[lf_index + 1 :]) |
There was a problem hiding this comment.
I would say html_escape is not for converting text to HTML.
There was a problem hiding this comment.
There was a problem hiding this comment.
could you please check it now?
There was a problem hiding this comment.
It's still not valid:
But I wonder if you have put a test and it's green, is it because v16 makes the conversion automatically, or is it because the test is not being executed?
In v15, I have just checked, and it's incorrect. Look at these 2 screenshots that are self-explanatory:
There was a problem hiding this comment.
Could you please check it now?
I do not know why there where some error test and was checked as green over here...
On v16 it is transform automatically, but if you add \n on text wont recognise, thats why i added a replace on field.
Im checking why user_type_id are not found...
carolinafernandez-tecnativa
force-pushed
the
16.0-imp-maintenance_account-name-invoice-line-equipment-description
branch
5 times, most recently
from
95a04f2 to
053a635
Compare
carolinafernandez-tecnativa
force-pushed
the
16.0-imp-maintenance_account-name-invoice-line-equipment-description
branch
from
053a635 to
55f3680
Compare
carolinafernandez-tecnativa
force-pushed
the
16.0-imp-maintenance_account-name-invoice-line-equipment-description
branch
2 times, most recently
from
06bd4c9 to
3c0b4e1
Compare
…ve line name TT47802
carolinafernandez-tecnativa
force-pushed
the
16.0-imp-maintenance_account-name-invoice-line-equipment-description
branch
from
3c0b4e1 to
39c327f
Compare
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at a17ba49. Thanks a lot for contributing to OCA. ❤️ |
pedrobaeza
deleted the
16.0-imp-maintenance_account-name-invoice-line-equipment-description
branch
@Tecnativa
TT47802
@pedrobaeza @victoralmau