[16.0][FIX] fieldservice: Fix location partner type #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houzefa-abba
changed the title
houzefa-abba
force-pushed
the
16.0-fix-location-partner-type
branch
2 times, most recently
from
00b04db to
64e1982
Compare
max3903
approved these changes
Apr 5, 2024
Service locations `fsm.location` create a partner `res.partner` through inheritance. Before this change, partners could be explicitely typed "fsm_location" when adding them within children of an existing partner, which in turn would automatically create service locations on top of them. But creating a service location by hand would not set that type on the partner created through inheritance. After this change, all partners built from service locations are typed the same. Fixes OCA#1128.
houzefa-abba
force-pushed
the
16.0-fix-location-partner-type
branch
from
64e1982 to
d0b370d
Compare
|
@houzefa-abba Do you have other changes to push or is this good to be merged? |
Hi this one is good to go, my latest change was only a rebase |
|
/ocabot merge minor |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at d416fda. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service locations
fsm.locationcreate a partnerres.partnerthrough inheritance.Before this change, partners could be explicitely typed "fsm_location" when adding them within children of an existing partner, which in turn would automatically create service locations on top of them.
But creating a service location by hand would not set that type on the partner created through inheritance. After this change, all partners built from service locations are typed the same.
Fixes #1128.