[16.0][IMP] fieldservice: Set location parent to owner #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houzefa-abba
force-pushed
the
16.0-location-partner-parent
branch
3 times, most recently
from
52ef55c to
b2dbc2c
Compare
Before this change, service location partners (created through inheritance) were typed "fsm_location" but did not always have a parent. When adding them within children of an existing partner, they of course did have a parent, but not the other way around: they had no parents when created, through inheritance, upon service location creation. After this change, service location partners are by default children of the service location owner partner. This is only done through defaults but not as related fields, which would break too much. Therefore, existing partners are not impacted by this change; only new ones created when creating a service location. See OCA#1128.
houzefa-abba
force-pushed
the
16.0-location-partner-parent
branch
from
b2dbc2c to
8769c66
Compare
|
Just rebased since #1164 got merged This PR is ready |
max3903
approved these changes
Apr 8, 2024
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 2a1349d. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, service location partners (created through
inheritance) were typed "fsm_location" but did not always have a parent.
When adding them within children of an existing partner, they of course
did have a parent, but not the other way around: they had no parents
when created, through inheritance, upon service location creation.
After this change, service location partners are by default children of
the service location owner partner.
This is only done through defaults but not as related fields, which
would break too much. Therefore, existing partners are not impacted by
this change; only new ones created when creating a service location.
See #1128.
This PR is a follow-up on #1164 where partner types got made more consistent.