-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] delivery_auto_refresh: compatibility with sale_tier_validation #815
[FIX] delivery_auto_refresh: compatibility with sale_tier_validation #815
Conversation
Fix OCA/server-ux#875 by actually implementing this sentence: https://github.com/OCA/delivery-carrier/blob/3a93f81bf3038e6ccb7fba4ce49376fe4f1422ee/delivery_auto_refresh/readme/DESCRIPTION.rst?plain=1#L3-L4 Now, auto-refreshing will be triggered only when modifying SO lines. Any other modifications will pass normally. @moduon MT-5997
And if delivery line depends on some sale order properties (other than lines)? |
In that case, that other field could be added to this check, just like I do now with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This have been working in production for 3 weeks and functionally problem is solved. 👍🏼
@rousseldenis did you read @yajo 's answer? 😄
Thank you!
This PR has the |
/ocabot rebase |
@rafaelbn The rebase process failed, because command
|
It seems #799 fixes OCA/server-ux#875 as part of the refactor. I don't know if on purpose or by accident, but we can close this. |
Fix OCA/server-ux#875 by actually implementing this sentence:
delivery-carrier/delivery_auto_refresh/readme/DESCRIPTION.rst
Lines 3 to 4 in 3a93f81
Now, auto-refreshing will be triggered only when modifying SO lines. Any other modifications will pass normally.
@moduon MT-5997