Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] base_delivery_carrier_label #807

Conversation

David-Luis-Mora
Copy link

No description provided.

yvaucher and others added 30 commits May 6, 2024 12:19
… nesting, few typos

[ADD] access rights for the shipping.label model
[IMP] remove unused pdf_list variable and rename pdf variable to label as a label can have other printing format

[IMP] remove readonly on carrier_tracking_ref

[IMP] remove carrier_tracking_ref redefinition as already defined in delivery/stock.py

[ADD] stock users rights

[ADD] file type on shipping label

[ADD] pot file

[ADD] fr.po
…per pack (stock.tracking)

[IMP] set tracking_id as an optional key of dict returned by label generation and improve doc string

[IMP] rename generate_pack_labels in generate_shipping_labels as it can also generate a single label for a picking without pack notion

[IMP] set labels on stock.picking instead of stock.picking.out in order to let the creation of return labels to provide to the customer

[FIX] xml view and copy what is needed on stock.picking.out and stock.picking.in as it won't be inherited from stock.picking.out
[FIX] delivery.carrier has no access rights for stock users, hence remove it for delivery.carrier.option
…by raising a orm.except_orm

[FIX] trigger carrier_id on change when creating a stock.picking to set default options from sale.order

[IMP] change error message of unimplemented default to a more user friendly message
…te the label only for a selection of packs in a picking

the button call action_generate_carrier_label() without the 'context' keyword argument so the context ends in the tracking_ids argument. So the method now conforms to the cr, uid, ids, context signature and just forwards to a new generate_labels() method that should be used from within the code

do not overwrite the option_ids on create of stock.picking if already set in values, generalize the method to all types of picking (added in/out)

Set the default options of the delivery method when it is changed and the options are not set (typically a write from the code or a mass update)
[FIX] action name

[IMP] add descrption field to carrier option
[IMP] file_type field inheritance in shipping.label

[IMP] add field selection sort
[FIX] docstring

[FIX] _customize_sender_address return method

[IMP] add comment in _customize_sender_adress()

[FIX] method name to get sender address

[FIX] method comment
move modules in __unported__
[REF] port to v8 with old api

[MIG] to v8 base_deliv_label, deliv_carrier_deposit

[IMP] add parcel_tracking field

[IMP] add _get_packages_from_picking()

add carrier_id in tree view
Better layout of default report for deposit slip
For stock.quant.package, order by id desc to have the latest first
Code cleanup

Button "Create Shipping Label" should be used when the picking in Done, because in v8 the packaging is handled in the "Transfer" wizard (in v7, the packaging could be made when the picking is waiting/ready)
Display number of packages on deposit slip
Add weight in tree view of packages
Remove an unused file 'reports.xml'

Remove the selection wrappers

Use the name of the method as string instead
Move module description in README.rst
Take the destination package. If empty, the package is moved so take the source
one.

The options must be filtered by the selected carrier
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
oca-ci and others added 17 commits May 6, 2024 12:19
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: delivery-carrier-16.0/delivery-carrier-16.0-base_delivery_carrier_label
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-base_delivery_carrier_label/
Currently translated at 10.8% (9 of 83 strings)

Translation: delivery-carrier-16.0/delivery-carrier-16.0-base_delivery_carrier_label
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-base_delivery_carrier_label/it/
Currently translated at 40.9% (34 of 83 strings)

Translation: delivery-carrier-16.0/delivery-carrier-16.0-base_delivery_carrier_label
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-base_delivery_carrier_label/sl/
…received in the data from the label generation
Currently translated at 100.0% (83 of 83 strings)

Translation: delivery-carrier-16.0/delivery-carrier-16.0-base_delivery_carrier_label
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-base_delivery_carrier_label/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: delivery-carrier-16.0/delivery-carrier-16.0-base_delivery_carrier_label
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-base_delivery_carrier_label/
Better use of logging so tools like sentry deduplicate the message.
Currently translated at 83.1% (69 of 83 strings)

Translation: delivery-carrier-16.0/delivery-carrier-16.0-base_delivery_carrier_label
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-base_delivery_carrier_label/fr/
Currently translated at 10.8% (9 of 83 strings)

Translation: delivery-carrier-16.0/delivery-carrier-16.0-base_delivery_carrier_label
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-base_delivery_carrier_label/it/
@David-Luis-Mora David-Luis-Mora mentioned this pull request May 6, 2024
34 tasks
@rousseldenis
Copy link
Contributor

/ocabot migration base_delivery_carrier_label

@rousseldenis
Copy link
Contributor

@David-Luis-Mora Thanks for this. Could you check tests ?

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone May 8, 2024
@yankinmax
Copy link
Contributor

yankinmax commented Jun 4, 2024

@David-Luis-Mora Can you pls double check the dependency: delivery should be stock_delivery as it has been changed in v17.
And fix the views:

<record id="view_picking_withcarrier_out_form" model="ir.ui.view">
    <field name="model">stock.picking</field>
    <field name="inherit_id" ref="delivery.view_picking_withcarrier_out_form" />
    <field name="arch" type="xml">
        <xpath expr="//page//field[@name='carrier_id']" position="after">
            <field name="carrier_code" />
            <field
                name="option_ids"
                domain="[('carrier_id', '=', carrier_id)]"
                widget="many2many_tags"
                options="{'color_field': 'color', 'no_create_edit': True}"
            />
        </xpath>
    </field>
</record>

Should inherit from stock_delivery.view_picking_withcarrier_out_form
Also stock_delivery.vpicktree_view_tree
Can you pls update?

@yankinmax
Copy link
Contributor

@David-Luis-Mora if you don't have time I can open a new PR to supersede yours and finish the job. Thanks in advance

@yankinmax
Copy link
Contributor

@David-Luis-Mora @rousseldenis
I've opened another PR including fixes of this one to speed up migration:

@rousseldenis
Copy link
Contributor

@yankinmax I think we can close this as @David-Luis-Mora has no more activity on github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.