Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] base_delivery_carrier_label: Migration to 17.0 #828

Merged
merged 99 commits into from
Jun 17, 2024

Conversation

yankinmax
Copy link
Contributor

This PR is opened to speed up base_delivery_carrier_label migration.
Depends and supersedes:

Sorry, something went wrong.

yvaucher and others added 30 commits June 5, 2024 08:15
… nesting, few typos

[ADD] access rights for the shipping.label model
[IMP] remove unused pdf_list variable and rename pdf variable to label as a label can have other printing format

[IMP] remove readonly on carrier_tracking_ref

[IMP] remove carrier_tracking_ref redefinition as already defined in delivery/stock.py

[ADD] stock users rights

[ADD] file type on shipping label

[ADD] pot file

[ADD] fr.po
…per pack (stock.tracking)

[IMP] set tracking_id as an optional key of dict returned by label generation and improve doc string

[IMP] rename generate_pack_labels in generate_shipping_labels as it can also generate a single label for a picking without pack notion

[IMP] set labels on stock.picking instead of stock.picking.out in order to let the creation of return labels to provide to the customer

[FIX] xml view and copy what is needed on stock.picking.out and stock.picking.in as it won't be inherited from stock.picking.out
[FIX] delivery.carrier has no access rights for stock users, hence remove it for delivery.carrier.option
…by raising a orm.except_orm

[FIX] trigger carrier_id on change when creating a stock.picking to set default options from sale.order

[IMP] change error message of unimplemented default to a more user friendly message
…te the label only for a selection of packs in a picking

the button call action_generate_carrier_label() without the 'context' keyword argument so the context ends in the tracking_ids argument. So the method now conforms to the cr, uid, ids, context signature and just forwards to a new generate_labels() method that should be used from within the code

do not overwrite the option_ids on create of stock.picking if already set in values, generalize the method to all types of picking (added in/out)

Set the default options of the delivery method when it is changed and the options are not set (typically a write from the code or a mass update)
[FIX] action name

[IMP] add descrption field to carrier option
[IMP] file_type field inheritance in shipping.label

[IMP] add field selection sort
[FIX] docstring

[FIX] _customize_sender_address return method

[IMP] add comment in _customize_sender_adress()

[FIX] method name to get sender address

[FIX] method comment
move modules in __unported__
[REF] port to v8 with old api

[MIG] to v8 base_deliv_label, deliv_carrier_deposit

[IMP] add parcel_tracking field

[IMP] add _get_packages_from_picking()

add carrier_id in tree view
Better layout of default report for deposit slip
For stock.quant.package, order by id desc to have the latest first
Code cleanup

Button "Create Shipping Label" should be used when the picking in Done, because in v8 the packaging is handled in the "Transfer" wizard (in v7, the packaging could be made when the picking is waiting/ready)
Display number of packages on deposit slip
Add weight in tree view of packages
Remove an unused file 'reports.xml'

Remove the selection wrappers

Use the name of the method as string instead
Move module description in README.rst
Take the destination package. If empty, the package is moved so take the source
one.

The options must be filtered by the selected carrier
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
OCA-git-bot and others added 17 commits June 7, 2024 10:29
Function delivery.carrier.alternative_send_shipping is called by
the override of send_shipping (if the call to its super didn't return
any result) and its result is returned by send_shipping.
However, as send_shipping is called by stock.picking.send_to_shipper
in the delivery module with a slicing operator, a list of at least
one element is expected and returning an empty dictionary is raising
a KeyError.
Instead of returning an empty dictionary, the function
alternative_send_shipping must return a list containing a dictionary
with keys `exact_price` and `tracking_number` because these keys are
used to access the result's values inside send_to_shipper function in
the delivery module.
…er_label and migrate base_delivery_carrier_label to 16
…received in the data from the label generation
Better use of logging so tools like sentry deduplicate the message.
@yankinmax yankinmax force-pushed the 17.0-mig-base_delivery_carrier_label branch from bb86426 to 3f9ad9f Compare June 7, 2024 07:29
Copy link

@vvrossem vvrossem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving

@yankinmax yankinmax force-pushed the 17.0-mig-base_delivery_carrier_label branch from 3f9ad9f to 99e3d58 Compare June 17, 2024 10:45
@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-828-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0f4db99 into OCA:17.0 Jun 17, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1540225. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet