- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] base_delivery_carrier_label: Migration to 17.0 #828
Merged
OCA-git-bot
merged 99 commits into
OCA:17.0
from
yankinmax:17.0-mig-base_delivery_carrier_label
Jun 17, 2024
Merged
[17.0][MIG] base_delivery_carrier_label: Migration to 17.0 #828
OCA-git-bot
merged 99 commits into
OCA:17.0
from
yankinmax:17.0-mig-base_delivery_carrier_label
Jun 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… nesting, few typos [ADD] access rights for the shipping.label model
[IMP] remove unused pdf_list variable and rename pdf variable to label as a label can have other printing format [IMP] remove readonly on carrier_tracking_ref [IMP] remove carrier_tracking_ref redefinition as already defined in delivery/stock.py [ADD] stock users rights [ADD] file type on shipping label [ADD] pot file [ADD] fr.po
…per pack (stock.tracking) [IMP] set tracking_id as an optional key of dict returned by label generation and improve doc string [IMP] rename generate_pack_labels in generate_shipping_labels as it can also generate a single label for a picking without pack notion [IMP] set labels on stock.picking instead of stock.picking.out in order to let the creation of return labels to provide to the customer [FIX] xml view and copy what is needed on stock.picking.out and stock.picking.in as it won't be inherited from stock.picking.out
[FIX] delivery.carrier has no access rights for stock users, hence remove it for delivery.carrier.option
…by raising a orm.except_orm [FIX] trigger carrier_id on change when creating a stock.picking to set default options from sale.order [IMP] change error message of unimplemented default to a more user friendly message
…te the label only for a selection of packs in a picking the button call action_generate_carrier_label() without the 'context' keyword argument so the context ends in the tracking_ids argument. So the method now conforms to the cr, uid, ids, context signature and just forwards to a new generate_labels() method that should be used from within the code do not overwrite the option_ids on create of stock.picking if already set in values, generalize the method to all types of picking (added in/out) Set the default options of the delivery method when it is changed and the options are not set (typically a write from the code or a mass update)
[FIX] action name [IMP] add descrption field to carrier option
[IMP] file_type field inheritance in shipping.label [IMP] add field selection sort
[FIX] docstring [FIX] _customize_sender_address return method [IMP] add comment in _customize_sender_adress() [FIX] method name to get sender address [FIX] method comment
move modules in __unported__
[REF] port to v8 with old api [MIG] to v8 base_deliv_label, deliv_carrier_deposit [IMP] add parcel_tracking field [IMP] add _get_packages_from_picking() add carrier_id in tree view
[FIX] complete view
Better layout of default report for deposit slip For stock.quant.package, order by id desc to have the latest first Code cleanup Button "Create Shipping Label" should be used when the picking in Done, because in v8 the packaging is handled in the "Transfer" wizard (in v7, the packaging could be made when the picking is waiting/ready) Display number of packages on deposit slip Add weight in tree view of packages
Remove an unused file 'reports.xml' Remove the selection wrappers Use the name of the method as string instead
Move module description in README.rst
Take the destination package. If empty, the package is moved so take the source one. The options must be filtered by the selected carrier
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
Function delivery.carrier.alternative_send_shipping is called by the override of send_shipping (if the call to its super didn't return any result) and its result is returned by send_shipping. However, as send_shipping is called by stock.picking.send_to_shipper in the delivery module with a slicing operator, a list of at least one element is expected and returning an empty dictionary is raising a KeyError. Instead of returning an empty dictionary, the function alternative_send_shipping must return a list containing a dictionary with keys `exact_price` and `tracking_number` because these keys are used to access the result's values inside send_to_shipper function in the delivery module.
…er_label and migrate base_delivery_carrier_label to 16
…received in the data from the label generation
Better use of logging so tools like sentry deduplicate the message.
bb86426
to
3f9ad9f
Compare
gurneyalex
approved these changes
Jun 17, 2024
vvrossem
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-approving
3f9ad9f
to
99e3d58
Compare
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 1540225. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is opened to speed up
base_delivery_carrier_label
migration.Depends and supersedes: