[16.0][FIX] delivery_auto_refresh: dynamic carrier line #797
+27
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toita86
force-pushed
the
16.0-IMP-delivery_auto_refresh
branch
from
f66d8db to
97d82dc
Compare
pedrobaeza
approved these changes
Apr 17, 2024
jbaudoux
requested changes
Apr 17, 2024
There was a problem hiding this comment.
Thanks for the forward port.
In my opinion, there are many issues in this module with how context variables are given and managed. The added code is increasing the complexity of the module instead of solving the source of the issue.
I have opened another PR #799 that fixes among other the way code is executed. I have taken over the tests change and addition from here.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fw port of