[14.0] [FIX] delivery_auto_refresh: dynamic carrier line #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renda-dev
commented
Mar 27, 2024
•
renda-dev
commented
- Re-proposing the fix that has been made in [14.0][FIX] delivery_auto_refresh #695 and removed in [IMP] delivery_auto_refresh: Compatibility with sale_tier_validation #656
- Fixed a test that should have failed when this feature was removed
- Proposing me and my team as maintainers for this module
renda-dev
force-pushed
the
14.0-fix-delivery_auto_refresh-carrier
branch
from
8541aca to
c9f70d7
Compare
renda-dev
force-pushed
the
14.0-fix-delivery_auto_refresh-carrier
branch
3 times, most recently
from
0a1c6e1 to
2e8a569
Compare
renda-dev
force-pushed
the
14.0-fix-delivery_auto_refresh-carrier
branch
from
2e8a569 to
556668a
Compare
|
@pedrobaeza good for you? we've added a test to ensure there's no regression. |
pedrobaeza
reviewed
Apr 9, 2024
renda-dev
force-pushed
the
14.0-fix-delivery_auto_refresh-carrier
branch
from
556668a to
ade5a71
Compare
pedrobaeza
approved these changes
Apr 10, 2024
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 2406552. Thanks a lot for contributing to OCA. ❤️ |
This was referenced Apr 16, 2024
@pedrobaeza done in |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.