[16.0][FIX] stock_picking_delivery_link: Test compatibility with purchase

[victoralmau]

Related to #755 (https://github.com/OCA/delivery-carrier/actions/runs/8269746616/job/22625732737)

Avoid test errors if the purchase module is installed

Please @pedrobaeza and @carolinafernandez-tecnativa can you review it?

@Tecnativa TT46563

[rousseldenis]

@victoralmau I don't like putting some code that depends on module that is not in dependencies...

[victoralmau]

@victoralmau I don't like putting some code that depends on module that is not in dependencies...

Ok, I understand, any suggestions to avoid tests failing if purchase is installed?

[carolinafernandez-tecnativa]

I have checked and it looks good to me, what do you think @pedrobaeza ?

[rousseldenis]

@victoralmau I don't like putting some code that depends on module that is not in dependencies...

Ok, I understand, any suggestions to avoid tests failing if purchase is installed?

@victoralmau Don't check purchase module. Fill in simply the seller_ids field as this is implemented in product.

[victoralmau]

@victoralmau I don't like putting some code that depends on module that is not in dependencies...

Ok, I understand, any suggestions to avoid tests failing if purchase is installed?

@victoralmau Don't check purchase module. Fill in simply the seller_ids field as this is implemented in product.

@victoralmau I don't like putting some code that depends on module that is not in dependencies...

Ok, I understand, any suggestions to avoid tests failing if purchase is installed?

@victoralmau Don't check purchase module. Fill in simply the seller_ids field as this is implemented in product.

Even if we do that we will still have to confirm the purchase and the tests will fail. Please try the following use case:

• Install stock_picking_delivery_link + purchase.
• Run the tests of stock_picking_delivery_link

[victoralmau]

Any other proposal to solve the tests of this module? This blocks #755

[victoralmau]

Any other better proposals to solve this problem? This blocks several migrations.

[carolinafernandez-tecnativa]

Can we procedure to merge? So we can unblock several migrations. Thanks!

[carolinafernandez-tecnativa]

Can we move forward to merge? @pedrobaeza @rousseldenis

[carolinafernandez-tecnativa]

@pedrobaeza What do you think?

[etobella]

Maybe it is cleaner to use

Suggested change

	cls.purchase_installed = False
	cls.purchase_installed = cls.env.ref("base.module_purchase").state == "installed"

[pedrobaeza]

@rousseldenis I have been 2 hours trying to get another solution in #755, but I see no other solution than this one.

The problem is that the tests test_put_in_pack_from_pick_with_wizard* of stock_picking_delivery_link works by chance: they create the stock.move with procure_method = "make_to_order", launching a procurement that is resolved with a lucky fallback to the rule "WH: Vendors → Stock", which creates an extra move for resolving move_orig_ids, but that's not possible when purchase_stock gets installed (or at least I'm not able to force it).

Can you propose an alternative or to not block this?

[carolinafernandez-tecnativa]

Hi, @rousseldenis have you checked what @pedrobaeza commented before?

[carolinafernandez-tecnativa]

Hi, any news? we need to unlock several migrations

[pedrobaeza]

Let's merge this as the less bad solution. Later, other options can be proposed:

/ocabot merge patch

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-781-by-pedrobaeza-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 3e3f888. Thanks a lot for contributing to OCA. ❤️