Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] [16.0] partner_resource_delivery_schedule #747

Conversation

Shide
Copy link
Contributor

@Shide Shide commented Dec 21, 2023

Allows to define a Calendar (and a resource) on a res.partner

This resource and calendar will be used to offer a better expected_date than Odoo does.
It takes in consideration Company calendar and Partner Resource and Calendar with his leaves too.

PR Series: #748

MT-4311 @moduon @yajo @EmilioPascual @rafaelbn please review if you want :)

@Shide
Copy link
Contributor Author

Shide commented Dec 21, 2023

This module delivery_partner_schedule tests are not failing, but other modules do.

@Shide Shide force-pushed the 16.0-delivery_partner_schedule-delivery_partner_schedule branch 2 times, most recently from dea342c to 57edcdb Compare December 21, 2023 12:34
@EmilioPascual
Copy link
Contributor

Thanks for this modules @Shide

When I try to test it, I couldn't select or create any avaliability resource

image

@Shide
Copy link
Contributor Author

Shide commented Jan 2, 2024

Thanks for this modules @Shide

When I try to test it, I couldn't select or create any avaliability resource

image

Start typing and you will see the create and edit options

@EmilioPascual
Copy link
Contributor

Thanks for this modules @Shide
When I try to test it, I couldn't select or create any avaliability resource
image

Start typing and you will see the create and edit options

Yes I tried, but I was not able to create a resource. I show you in following video:
https://www.loom.com/share/7810f26218e24d6ca2798018e8e76fe5

@Shide Shide force-pushed the 16.0-delivery_partner_schedule-delivery_partner_schedule branch from 57edcdb to 93c921d Compare January 15, 2024 09:57
@Shide
Copy link
Contributor Author

Shide commented Jan 15, 2024

@EmilioPascual you can create it as you will expect

@Shide Shide force-pushed the 16.0-delivery_partner_schedule-delivery_partner_schedule branch from 93c921d to f4fb3f9 Compare January 16, 2024 06:44
@Shide Shide changed the title [ADD] [16.0] delivery_partner_schedule [ADD] [16.0] partner_resource_delivery_schedule Jan 16, 2024
@Shide
Copy link
Contributor Author

Shide commented Jan 16, 2024

Module renamed

@Shide Shide requested a review from EmilioPascual January 16, 2024 06:48
@rafaelbn rafaelbn added this to the 16.0 milestone Jan 19, 2024
@Shide Shide marked this pull request as draft January 22, 2024 11:48
@Shide Shide force-pushed the 16.0-delivery_partner_schedule-delivery_partner_schedule branch from f4fb3f9 to 69a9674 Compare January 23, 2024 12:22
@Shide Shide marked this pull request as ready for review January 23, 2024 12:24
@Shide
Copy link
Contributor Author

Shide commented Jan 23, 2024

I've changed a bit the module to simplify process and improve UX:

  • A new button appears to: create a resource and show a calendar.
  • When calendar changes, it's written too in the resource of the contact

https://www.loom.com/share/19005ee119b046758340f7c4b344afb6

@Shide Shide requested a review from EmilioPascual January 23, 2024 12:30
@Shide
Copy link
Contributor Author

Shide commented Jan 23, 2024

@rafaelbn @fcvalgar @Gelojr @EmilioPascual plz review if you want :)

Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

LGTM, Thank you @Shide

2024-01-23_16-33
2024-01-23_16-33_1
image

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Some suggestions, nothing blocking. Good one!

@Shide Shide force-pushed the 16.0-delivery_partner_schedule-delivery_partner_schedule branch from 69a9674 to cdae4d0 Compare January 24, 2024 08:19
Copy link
Contributor

@EmilioPascual EmilioPascual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One user with sales administrator group cannot create a delivery schedule calendar.
I show you in the following recording https://www.loom.com/share/57a81d467a274252a35f08423800fdb2
Any user with sales group should be able to create a delivery schedule calendar.

@Shide Shide force-pushed the 16.0-delivery_partner_schedule-delivery_partner_schedule branch 2 times, most recently from fba1dc8 to 9196a50 Compare January 25, 2024 10:35
@Shide
Copy link
Contributor Author

Shide commented Jan 25, 2024

Tests are failing on other module.

@yajo
Copy link
Member

yajo commented Jan 29, 2024

Try setting the module that fails (and its dependencies, if any) as rebel by using the template.

@Shide Shide force-pushed the 16.0-delivery_partner_schedule-delivery_partner_schedule branch from 9196a50 to b479d2b Compare February 1, 2024 11:27
@Shide
Copy link
Contributor Author

Shide commented Feb 1, 2024

I've changed the way that the available date is set on the sales order.

I've added a small button (>>) to suggest the next available date on the commitment field.
If you click again the button, a new date is calculated from the prior one.

This behavior respects Odoo expected date in case you won't need to promise anything to the customer.

@rafaelbn @rousseldenis what do you think?

@Shide Shide force-pushed the 16.0-delivery_partner_schedule-delivery_partner_schedule branch from b479d2b to 42e562f Compare February 1, 2024 11:36
Copy link

@Gelojr Gelojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Shide
It seems that when you create a new client, the selection field does not work until you start typing and create a new calendar.
But when you do, the rest of the calendars do not appear. Is it OK?
https://www.loom.com/share/7718a4c33dc3484495f2d0a3fa2059ec?sid=6ec590e3-90df-4f7a-80a9-61199f691dda

@Shide
Copy link
Contributor Author

Shide commented Feb 2, 2024

Hello @Shide It seems that when you create a new client, the selection field does not work until you start typing and create a new calendar. But when you do, the rest of the calendars do not appear. Is it OK? https://www.loom.com/share/7718a4c33dc3484495f2d0a3fa2059ec?sid=6ec590e3-90df-4f7a-80a9-61199f691dda

Yes, because by default, the company calendar is assigned.
When you want to choose another calendar, the domain is applied.

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel it. I promise A deep review, with love 💕❤️

@Shide Shide marked this pull request as draft February 13, 2024 07:55
@Shide
Copy link
Contributor Author

Shide commented Feb 13, 2024

I'm going to think about this PR and rebuild the solution again with something less generic (resource.calendar) that uses non general permissions.

@rousseldenis
Copy link
Contributor

I'm going to think about this PR and rebuild the solution again with something less generic (resource.calendar) that uses non general permissions.

@Shide FYI, there is already something : OCA/stock-logistics-workflow#1378

@Shide
Copy link
Contributor Author

Shide commented Feb 13, 2024

I'm going to think about this PR and rebuild the solution again with something less generic (resource.calendar) that uses non general permissions.

@Shide FYI, there is already something : OCA/stock-logistics-workflow#1378

We know, but this solution is not what we are looking for

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 16, 2024
@github-actions github-actions bot closed this Jul 21, 2024
@yajo yajo deleted the 16.0-delivery_partner_schedule-delivery_partner_schedule branch July 25, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants