-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] [16.0] partner_resource_delivery_schedule #747
[ADD] [16.0] partner_resource_delivery_schedule #747
Conversation
This module |
dea342c
to
57edcdb
Compare
Thanks for this modules @Shide When I try to test it, I couldn't select or create any avaliability resource |
Start typing and you will see the create and edit options |
Yes I tried, but I was not able to create a resource. I show you in following video: |
57edcdb
to
93c921d
Compare
@EmilioPascual you can create it as you will expect |
93c921d
to
f4fb3f9
Compare
Module renamed |
f4fb3f9
to
69a9674
Compare
I've changed a bit the module to simplify process and improve UX:
|
@rafaelbn @fcvalgar @Gelojr @EmilioPascual plz review if you want :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: Some suggestions, nothing blocking. Good one!
69a9674
to
cdae4d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One user with sales administrator group cannot create a delivery schedule calendar.
I show you in the following recording https://www.loom.com/share/57a81d467a274252a35f08423800fdb2
Any user with sales group should be able to create a delivery schedule calendar.
fba1dc8
to
9196a50
Compare
Tests are failing on other module. |
Try setting the module that fails (and its dependencies, if any) as rebel by using the template. |
9196a50
to
b479d2b
Compare
I've changed the way that the available date is set on the sales order. I've added a small button (>>) to suggest the next available date on the commitment field. This behavior respects Odoo expected date in case you won't need to promise anything to the customer. @rafaelbn @rousseldenis what do you think? |
b479d2b
to
42e562f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Shide
It seems that when you create a new client, the selection field does not work until you start typing and create a new calendar.
But when you do, the rest of the calendars do not appear. Is it OK?
https://www.loom.com/share/7718a4c33dc3484495f2d0a3fa2059ec?sid=6ec590e3-90df-4f7a-80a9-61199f691dda
Yes, because by default, the company calendar is assigned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel it. I promise A deep review, with love 💕❤️
I'm going to think about this PR and rebuild the solution again with something less generic (resource.calendar) that uses non general permissions. |
@Shide FYI, there is already something : OCA/stock-logistics-workflow#1378 |
We know, but this solution is not what we are looking for |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Allows to define a Calendar (and a resource) on a res.partner
This resource and calendar will be used to offer a better expected_date than Odoo does.
It takes in consideration Company calendar and Partner Resource and Calendar with his leaves too.
PR Series: #748
MT-4311 @moduon @yajo @EmilioPascual @rafaelbn please review if you want :)