Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] delivery_carrier_label_gls #599

Closed
wants to merge 13 commits into from
Closed

[16.0][MIG] delivery_carrier_label_gls #599

wants to merge 13 commits into from

Conversation

glitchov
Copy link
Contributor

Migration from a 10.0

@rousseldenis
Copy link
Contributor

/ocabot migration delivery_carrier_label_gls

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jan 17, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 17, 2023
Open
32 tasks
@glitchov glitchov force-pushed the 16.0-mig-delivery_carrier_label_gls-hda branch from 661191a to c58e234 Compare January 17, 2023 10:20
lmignon
lmignon approved these changes Jan 17, 2023
View reviewed changes
Copy link

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @glitchov Seems to be a huge work. LGTM (Code + Functional)

A nice to have would be to have the migration scripts (may be in a next step when we'll need these)

jbaudoux
jbaudoux requested changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work.
Some minor remarks

@glitchov glitchov force-pushed the 16.0-mig-delivery_carrier_label_gls-hda branch from c58e234 to 8d7564a Compare March 13, 2023 10:56
@glitchov glitchov requested a review from jbaudoux March 13, 2023 11:01
@glitchov glitchov force-pushed the 16.0-mig-delivery_carrier_label_gls-hda branch from b8e3aa0 to db253a1 Compare March 27, 2023 16:11
@rousseldenis
Copy link
Contributor

@jbaudoux Could you update your review ?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Contributor

Mmmh, @glitchov Could you remove the merge commit ? To rebase, you should rebase and not merge base branch.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Contributor

@glitchov

@glitchov glitchov force-pushed the 16.0-mig-delivery_carrier_label_gls-hda branch from db253a1 to 0f06fa4 Compare April 3, 2023 07:57
@rousseldenis
Copy link
Contributor

@glitchov It seems your commits are in weird order. Could you check ?

@glitchov glitchov force-pushed the 16.0-mig-delivery_carrier_label_gls-hda branch from 0f06fa4 to 7a366cf Compare May 5, 2023 12:20
@glitchov glitchov force-pushed the 16.0-mig-delivery_carrier_label_gls-hda branch from 7a366cf to d561ee4 Compare July 25, 2023 10:40
@glitchov glitchov force-pushed the 16.0-mig-delivery_carrier_label_gls-hda branch 3 times, most recently from 2429223 to f1d9724 Compare August 18, 2023 13:21
@rousseldenis
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-599-by-rousseldenis-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 6, 2024
@OCA-git-bot
Merge PR #599 into 16.0
faf3874 
Signed-off-by rousseldenis
@OCA-git-bot
Copy link
Contributor

@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-599-by-rousseldenis-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@rousseldenis
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-599-by-rousseldenis-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 7, 2024
@OCA-git-bot
Merge PR #599 into 16.0
13f54a9 
Signed-off-by rousseldenis
@OCA-git-bot
Copy link
Contributor

@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-599-by-rousseldenis-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

sbidoul and others added 13 commits May 7, 2024 15:51
@sbidoul @rousseldenis
[MOV] move addons out of __unported__ (they remain not installable)
f2809be
@pedrobaeza @rousseldenis
[MIG] Rename manifest files
a0c6395
@sbidoul @rousseldenis
remove obsolete .pot files [ci skip]
116d02e
@rousseldenis
[10.0][MIG][REF][IMP] delivery_carrier_label_gls: using the internati…
cff774f 
…onal REST API

Note that the international API is not available everywhere,
notably not in France, but available in Belgium, Luxembourg, Germany, Austria.
Ask your local GLS for the availability of the web service.
@glitchov @rousseldenis
[IMP] delivery_carrier_label_gls: black, isort, prettier
36b38f6
@glitchov @rousseldenis
[MIG] delivery_carrier_label_gls: Migration to 16.0
ab3c9dd
@glitchov @rousseldenis
[MIG][16.0] delivery_carrier_label_gls: add migration script
9c34993
@glitchov @rousseldenis
[IMP] delivery_carrier_label_gls : fr translation
897e835
@glitchov @rousseldenis
[FIX] delivery_carrier_label_gls : uncomplete report definition
f0f1a09
@glitchov @rousseldenis
[FIX] delivery_carrier_label_gls : typo in fr translation
a16db43
@glitchov @rousseldenis
[IMP] delivery_carrier_label_gls : header info in report
d9b63d0
@glitchov @rousseldenis
[FIX] delivery_carrier_label_gls: bootstrap class text-right rplaced …
b193d61 
…by text-end
@rousseldenis
[IMP] delivery_carrier_label_gls: Improve tests flow
b27e1d3
@rousseldenis rousseldenis force-pushed the 16.0-mig-delivery_carrier_label_gls-hda branch from eee5dd2 to b27e1d3 Compare May 8, 2024 06:30
@liebana
Copy link

liebana commented May 31, 2024

Hello! Can this be merged? @rousseldenis

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 29, 2024
@github-actions github-actions bot closed this Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmignon lmignon lmignon approved these changes

@jbaudoux jbaudoux jbaudoux approved these changes

@aliciagaarzo aliciagaarzo aliciagaarzo approved these changes

Assignees
No one assigned
Labels
approved migration needs review ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.