[IMP] delivery_carrier_label_gls: Improve tests flow

rousseldenis · rousseldenis · commit b27e1d381c02 · 2024-05-08T08:30:24.000+02:00
diff --git a/delivery_carrier_label_gls/README.rst b/delivery_carrier_label_gls/README.rst
@@ -2,10 +2,13 @@
 Delivery Carrier Label GLS
 ==========================
 
-.. !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+.. 
+   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
    !! This file is generated by oca-gen-addon-readme !!
    !! changes will be overwritten.                   !!
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+   !! source digest: sha256:06fda2250228b5c5afd09c2a72b1045f9a0c3d98a770787b50dbc78bb50d9ba7
+   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 
 .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
     :target: https://odoo-community.org/page/development-status
@@ -20,10 +23,10 @@ Delivery Carrier Label GLS
     :target: https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-delivery_carrier_label_gls
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/webui/builds.html?repo=OCA/delivery-carrier&target_branch=16.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/delivery-carrier&target_branch=16.0
     :alt: Try me on Runboat
 
-|badge1| |badge2| |badge3| |badge4| |badge5| 
+|badge1| |badge2| |badge3| |badge4| |badge5|
 
 Integration with GLS shipping webservices.
 Documentation:
@@ -73,7 +76,7 @@ Bug Tracker
 
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/delivery-carrier/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
-If you spotted it first, help us smashing it by providing a detailed and welcomed
+If you spotted it first, help us to smash it by providing a detailed and welcomed
 `feedback <https://github.com/OCA/delivery-carrier/issues/new?body=module:%20delivery_carrier_label_gls%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
diff --git a/delivery_carrier_label_gls/static/description/index.html b/delivery_carrier_label_gls/static/description/index.html
@@ -1,20 +1,19 @@
-<?xml version="1.0" encoding="utf-8" ?>
 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
 <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
 <head>
 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
-<meta name="generator" content="Docutils: http://docutils.sourceforge.net/" />
+<meta name="generator" content="Docutils: https://docutils.sourceforge.io/" />
 <title>Delivery Carrier Label GLS</title>
 <style type="text/css">
 
 /*
 :Author: David Goodger (goodger@python.org)
-:Id: $Id: html4css1.css 7952 2016-07-26 18:15:59Z milde $
+:Id: $Id: html4css1.css 8954 2022-01-20 10:10:25Z milde $
 :Copyright: This stylesheet has been placed in the public domain.
 
 Default cascading style sheet for the HTML output of Docutils.
 
-See http://docutils.sf.net/docs/howto/html-stylesheets.html for how to
+See https://docutils.sourceforge.io/docs/howto/html-stylesheets.html for how to
 customize this style sheet.
 */
 
@@ -366,27 +365,29 @@ <h1 class="title">Delivery Carrier Label GLS</h1>
 <!-- !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! This file is generated by oca-gen-addon-readme !!
 !! changes will be overwritten.                   !!
+!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+!! source digest: sha256:06fda2250228b5c5afd09c2a72b1045f9a0c3d98a770787b50dbc78bb50d9ba7
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external" href="https://github.com/OCA/delivery-carrier/tree/16.0/delivery_carrier_label_gls"><img alt="OCA/delivery-carrier" src="https://img.shields.io/badge/github-OCA%2Fdelivery--carrier-lightgray.png?logo=github" /></a> <a class="reference external" href="https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-delivery_carrier_label_gls"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external" href="https://runboat.odoo-community.org/webui/builds.html?repo=OCA/delivery-carrier&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/delivery-carrier/tree/16.0/delivery_carrier_label_gls"><img alt="OCA/delivery-carrier" src="https://img.shields.io/badge/github-OCA%2Fdelivery--carrier-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-delivery_carrier_label_gls"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/delivery-carrier&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>Integration with GLS shipping webservices.
 Documentation:
 <a class="reference external" href="http://gls-shipit.gls-group.eu/webservices/2_8_11/doxygen/WS-REST-API/index.html">http://gls-shipit.gls-group.eu/webservices/2_8_11/doxygen/WS-REST-API/index.html</a></p>
 <p><strong>Table of contents</strong></p>
 <div class="contents local topic" id="contents">
 <ul class="simple">
-<li><a class="reference internal" href="#configuration" id="id1">Configuration</a></li>
-<li><a class="reference internal" href="#usage" id="id2">Usage</a></li>
-<li><a class="reference internal" href="#bug-tracker" id="id3">Bug Tracker</a></li>
-<li><a class="reference internal" href="#credits" id="id4">Credits</a><ul>
-<li><a class="reference internal" href="#authors" id="id5">Authors</a></li>
-<li><a class="reference internal" href="#contributors" id="id6">Contributors</a></li>
-<li><a class="reference internal" href="#maintainers" id="id7">Maintainers</a></li>
+<li><a class="reference internal" href="#configuration" id="toc-entry-1">Configuration</a></li>
+<li><a class="reference internal" href="#usage" id="toc-entry-2">Usage</a></li>
+<li><a class="reference internal" href="#bug-tracker" id="toc-entry-3">Bug Tracker</a></li>
+<li><a class="reference internal" href="#credits" id="toc-entry-4">Credits</a><ul>
+<li><a class="reference internal" href="#authors" id="toc-entry-5">Authors</a></li>
+<li><a class="reference internal" href="#contributors" id="toc-entry-6">Contributors</a></li>
+<li><a class="reference internal" href="#maintainers" id="toc-entry-7">Maintainers</a></li>
 </ul>
 </li>
 </ul>
 </div>
 <div class="section" id="configuration">
-<h1><a class="toc-backref" href="#id1">Configuration</a></h1>
+<h1><a class="toc-backref" href="#toc-entry-1">Configuration</a></h1>
 <p>To start using GLS, you need to configure two types of settings in
 <em>Inventory - Configuration- Delivery</em> or <em>Inventory - Configuration - Settings</em>
 which leads to the right section in inventory global settings.
@@ -400,7 +401,7 @@ <h1><a class="toc-backref" href="#id1">Configuration</a></h1>
 <p>For client integration tests you need to fill your credentials in the tests/common.py.</p>
 </div>
 <div class="section" id="usage">
-<h1><a class="toc-backref" href="#id2">Usage</a></h1>
+<h1><a class="toc-backref" href="#toc-entry-2">Usage</a></h1>
 <p>Create the packages on GLS which returns a tracking ID.
 If there is any kind of mistake (address, weight),
 it is possible to cancel it as long as it has not been scanned yet.
@@ -415,24 +416,24 @@ <h1><a class="toc-backref" href="#id2">Usage</a></h1>
 next day, and provided with the next report if there is one.</p>
 </div>
 <div class="section" id="bug-tracker">
-<h1><a class="toc-backref" href="#id3">Bug Tracker</a></h1>
+<h1><a class="toc-backref" href="#toc-entry-3">Bug Tracker</a></h1>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/delivery-carrier/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
-If you spotted it first, help us smashing it by providing a detailed and welcomed
+If you spotted it first, help us to smash it by providing a detailed and welcomed
 <a class="reference external" href="https://github.com/OCA/delivery-carrier/issues/new?body=module:%20delivery_carrier_label_gls%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
-<h1><a class="toc-backref" href="#id4">Credits</a></h1>
+<h1><a class="toc-backref" href="#toc-entry-4">Credits</a></h1>
 <div class="section" id="authors">
-<h2><a class="toc-backref" href="#id5">Authors</a></h2>
+<h2><a class="toc-backref" href="#toc-entry-5">Authors</a></h2>
 <ul class="simple">
 <li>Acsone</li>
 <li>Akretion</li>
 </ul>
 </div>
 <div class="section" id="contributors">
-<h2><a class="toc-backref" href="#id6">Contributors</a></h2>
+<h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2>
 <ul class="simple">
 <li>David Beal &#64; Akretion</li>
 <li>Nans Lefebvre &lt;<a class="reference external" href="mailto:nans.lefebvre&#64;acsone.eu">nans.lefebvre&#64;acsone.eu</a>&gt;</li>
@@ -441,7 +442,7 @@ <h2><a class="toc-backref" href="#id6">Contributors</a></h2>
 </ul>
 </div>
 <div class="section" id="maintainers">
-<h2><a class="toc-backref" href="#id7">Maintainers</a></h2>
+<h2><a class="toc-backref" href="#toc-entry-7">Maintainers</a></h2>
 <p>This module is maintained by the OCA.</p>
 <a class="reference external image-reference" href="https://odoo-community.org"><img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" /></a>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
diff --git a/delivery_carrier_label_gls/tests/common.py b/delivery_carrier_label_gls/tests/common.py
@@ -36,22 +36,7 @@ def _get_gls_carrier_account_vals(cls):
     def setUpClass(cls):
         super().setUpClass()
         cls.company = cls.env.user.company_id
-        vals_gls_product = {
-            "default_code": "Code ship GLS",
-            "type": "service",
-            "sale_ok": False,
-            "name": "Name ship GLS",
-        }
-        cls.gls_product = cls.env["product.product"].create(vals_gls_product)
-        vals_gls_carrier_account = cls._get_gls_carrier_account_vals()
-        cls.gls_carrier_account = cls.env["carrier.account"].create(
-            vals_gls_carrier_account
-        )
-        vals_gls_carrier = cls._get_gls_carrier_vals()
-        cls.gls_carrier = cls.env["delivery.carrier"].create(vals_gls_carrier)
-        cls.gls_client = cls.env["delivery.client.gls"].create(
-            {"carrier_id": cls.gls_carrier.id}
-        )
+
         vals_product = {"name": "product", "type": "product", "weight": 0.5}
         cls.product = cls.env["product.product"].create(vals_product)
         vals_partner = {
@@ -69,6 +54,9 @@ def setUpClass(cls):
         )
         cls.customer_location = cls.env.ref("stock.stock_location_customers")
         cls.gls_parcel_shop = "0560005537"
+
+    @classmethod
+    def _create_sale_order(cls):
         vals_sale_order = {
             "partner_id": cls.partner.id,
             "gls_parcel_shop": cls.gls_parcel_shop,
@@ -82,6 +70,33 @@ def setUpClass(cls):
         }
         cls.order_line = cls.env["sale.order.line"].create(vals_order_line)
 
+    @classmethod
+    def _create_gls_account(cls):
+        vals_gls_carrier_account = cls._get_gls_carrier_account_vals()
+        cls.gls_carrier_account = cls.env["carrier.account"].create(
+            vals_gls_carrier_account
+        )
+
+    @classmethod
+    def _create_gls_product(cls):
+        vals_gls_product = {
+            "default_code": "Code ship GLS",
+            "type": "service",
+            "sale_ok": False,
+            "name": "Name ship GLS",
+        }
+        cls.gls_product = cls.env["product.product"].create(vals_gls_product)
+
+    @classmethod
+    def _create_gls_carrier(cls):
+        cls._create_gls_account()
+        cls._create_gls_product()
+        vals_gls_carrier = cls._get_gls_carrier_vals()
+        cls.gls_carrier = cls.env["delivery.carrier"].create(vals_gls_carrier)
+        cls.gls_client = cls.env["delivery.client.gls"].create(
+            {"carrier_id": cls.gls_carrier.id}
+        )
+
 
 @contextmanager
 def mock_gls_client(mock_client=None):
diff --git a/delivery_carrier_label_gls/tests/test_carrier_constraints.py b/delivery_carrier_label_gls/tests/test_carrier_constraints.py
@@ -13,6 +13,12 @@
 
 
 class TestCarrierConstraints(TestGLS):
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        cls._create_gls_account()
+        cls._create_gls_product()
+
     def test_missing_field(self):
         for field in gls_required_fields:
             values = self._get_gls_carrier_vals()
diff --git a/delivery_carrier_label_gls/tests/test_flow.py b/delivery_carrier_label_gls/tests/test_flow.py
@@ -7,6 +7,12 @@
 
 
 class TestGlsFlow(TestGLS):
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        cls._create_gls_carrier()
+        cls._create_sale_order()
+
     def test_flow(self):
         """We test the complete flow, since actions depend on each other.
         To call cancel, you need to call create before; same with the report.
diff --git a/delivery_carrier_label_gls/tests/test_gls_client.py b/delivery_carrier_label_gls/tests/test_gls_client.py
@@ -12,6 +12,12 @@
 # and shipping method.
 @unittest.skip("gls_client")
 class TestGlsClient(TestGLS):
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        cls._create_gls_carrier()
+        cls._create_sale_order()
+
     @property
     def create_payload(self):
         return {
diff --git a/delivery_carrier_label_gls/tests/test_partner.py b/delivery_carrier_label_gls/tests/test_partner.py
@@ -7,6 +7,12 @@
 
 
 class TestPartner(TestGLS):
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        cls._create_gls_carrier()
+        cls._create_sale_order()
+
     def test_belgian_zip(self):
         """Check that we have a string formatting parameter"""
         expected = "1367"
