Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mdbook-pdf-outline: 0.1.4 -> 0.1.6 #383630

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

mdbook-pdf-outline: 0.1.4 -> 0.1.6 #383630

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7d23e0
mdbook-pdf-outline: 0.1.4 -> 0.1.6
HollowMan6 Mar 11, 2025
d7ef4f4
mdbook-pdf-outline: change maintainer
HollowMan6 Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkgs/by-name/md/mdbook-pdf-outline/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@
}:

python3Packages.buildPythonApplication rec {
pname = "mdbook-pdf-outline";
version = "0.1.4";
pname = "mdbook_pdf_outline";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change of package source is non-trivial (as pname here is also taken by fetchPyPI to form src), but there lacks explanation in the commit description and the PR description.

Could you elaborate the reason behind such change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing! I have added the explanation in the commit description and the PR description:

Rename pname from mdbook-pdf-outline to mdbook_pdf_outline
due to PyPI tarball name change. Reference:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SuperSandro2000 Do you think we should change the pname styling of a Python package upon the upstream tarball name changes, or define the pname for fetchPypi separately?

version = "0.1.6";
pyproject = true;

src = fetchPypi {
inherit pname version;
hash = "sha256-STi+54iT+5+Xi0IzGXv2dxVS91+T6fjg3xmbJjekpPE=";
hash = "sha256-GPTDlgYpfPtcq+rJCjxgexfViYiqHoVZ8iQkyWXNogw=";
};

nativeBuildInputs = [
Expand All @@ -26,7 +26,7 @@ python3Packages.buildPythonApplication rec {
meta = with lib; {
homepage = "https://github.com/HollowMan6/mdbook-pdf";
license = licenses.gpl3Plus;
maintainers = with maintainers; [ nix-julia ];
maintainers = with maintainers; [ hollowman6 ];

};
}