Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mdbook-pdf-outline: 0.1.4 -> 0.1.6 #383630

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

mdbook-pdf-outline: 0.1.4 -> 0.1.6 #383630

wants to merge 2 commits into from

Conversation

HollowMan6
Copy link
Member

@HollowMan6 HollowMan6 commented Feb 20, 2025 •
edited
Loading

Rename pname from mdbook-pdf-outline to mdbook_pdf_outline
due to PyPI tarball name change. Reference:

Change maintainer from nix-julia to hollowman6 as agreed.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 24, 2025
@HollowMan6 HollowMan6 force-pushed the mdbook-pdf-outline-update branch from f5137ed to 459a0ba Compare March 9, 2025 21:11
@HollowMan6 HollowMan6 changed the title mdbook-pdf-outline: 0.1.4 -> 0.1.5 mdbook-pdf-outline: 0.1.4 -> 0.1.6 Mar 9, 2025
@HollowMan6 HollowMan6 requested a review from nix-julia March 9, 2025 21:13
@HollowMan6 HollowMan6 force-pushed the mdbook-pdf-outline-update branch 2 times, most recently from 2c68fb7 to 25ee8d8 Compare March 9, 2025 21:18
@HollowMan6 HollowMan6 force-pushed the mdbook-pdf-outline-update branch 2 times, most recently from 5d4e34a to c8e9966 Compare March 10, 2025 14:01
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5273

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 11, 2025
ShamrockLee
ShamrockLee requested changes Mar 11, 2025
View reviewed changes
pkgs/by-name/md/mdbook-pdf-outline/package.nix
@@ -5,13 +5,13 @@
}:

python3Packages.buildPythonApplication rec {
pname = "mdbook-pdf-outline";
version = "0.1.4";
pname = "mdbook_pdf_outline";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change of package source is non-trivial (as pname here is also taken by fetchPyPI to form src), but there lacks explanation in the commit description and the PR description.

Could you elaborate the reason behind such change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing! I have added the explanation in the commit description and the PR description:

Rename pname from mdbook-pdf-outline to mdbook_pdf_outline
due to PyPI tarball name change. Reference:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SuperSandro2000 Do you think we should change the pname styling of a Python package upon the upstream tarball name changes, or define the pname for fetchPypi separately?

@HollowMan6
mdbook-pdf-outline: 0.1.4 -> 0.1.6
a7d23e0 
Rename `pname` from `mdbook-pdf-outline` to `mdbook_pdf_outline`
due to PyPI tarball name change. Reference:

- https://pypi.org/project/mdbook-pdf-outline/0.1.4/#files
- https://pypi.org/project/mdbook-pdf-outline/0.1.6/#files

Signed-off-by: Hollow Man <hollowman@opensuse.org>
@HollowMan6
mdbook-pdf-outline: change maintainer
d7ef4f4 
from `nix-julia` to `hollowman6` as agreed

Signed-off-by: Hollow Man <hollowman@opensuse.org>
@HollowMan6 HollowMan6 force-pushed the mdbook-pdf-outline-update branch from c8e9966 to d7ef4f4 Compare March 11, 2025 14:29
@HollowMan6 HollowMan6 requested a review from ShamrockLee March 11, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nix-julia nix-julia nix-julia approved these changes

@ShamrockLee ShamrockLee Awaiting requested review from ShamrockLee

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HollowMan6 @nixos-discourse @ShamrockLee @nix-julia @wegank