python312Packages.textual: 1.0.0 -> 2.1.2 #382551
Open
+113
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gepbird
force-pushed
the
textual-2.0.0
branch
from
d18cc49 to
635e066
Compare
gepbird
commented
Feb 16, 2025
gepbird
commented
Feb 16, 2025
| @@ -45,6 +46,10 @@ buildPythonPackage rec { | |||
|
|
|||
| pythonImportsCheck = [ "pytest_textual_snapshot" ]; | |||
|
|
|||
| postInstall = '' | |||
| cp -r resources $out/${python3.sitePackages}/ | |||
There was a problem hiding this comment.
Before when snapshot tests fail (for example with memray), there was an error that it cannot find pytest-textual-snapshots/.../resources/..., no useful info why the tests failed. With this an HTML report gets generated.
gepbird
force-pushed
the
textual-2.0.0
branch
from
41aa007 to
55f3a33
Compare
gepbird
changed the title
gepbird
force-pushed
the
textual-2.0.0
branch
from
55f3a33 to
fd10be7
Compare
gepbird
changed the title
gepbird
force-pushed
the
textual-2.0.0
branch
from
fd10be7 to
7be1a19
Compare
|
So far everything builds except
|
gepbird
changed the title
|
Looks like the 2.0.1 failure was fixed in 2.0.3
|
gepbird
force-pushed
the
textual-2.0.0
branch
from
ca1354c to
b96a59e
Compare
gepbird
changed the title
|
|
Apart from regression in those 2 packages due to API changes, this is ready. |
gepbird
force-pushed
the
textual-2.0.0
branch
2 times, most recently
from
79a0edf to
085bcdf
Compare
gepbird
force-pushed
the
textual-2.0.0
branch
from
085bcdf to
8975497
Compare
|
|
gepbird
force-pushed
the
textual-2.0.0
branch
from
8975497 to
ce22340
Compare
gepbird
changed the title
gepbird
changed the title
|
|
Rebased to master as memray was updated to a newer stable version, adding support for textual 2 (#387797) |
|
13 tasks
There was a problem hiding this comment.
Let's go with your PR, I'll close #388904.
Could you please pick the patch I have made to textual-autocomplete please?
13 tasks
13 tasks
gepbird
commented
Mar 11, 2025
pkgs/development/python-modules/textual-autocomplete/default.nix
Outdated
Show resolved
Hide resolved
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Releases:
Packages depending on textual may have some regressions, as there were some API changes.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.