-
-
Notifications
You must be signed in to change notification settings - Fork 15.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "coreutils: 8.32 -> 9.0" for darwin only #142836
Conversation
Please copy the coreutils file from version 8.32 and copy it into a separate file and then we give that darwin so that we can keep the 9.0 for linux. |
19e2c16
to
5a30427
Compare
I've only reverted the change for darwin. |
5a30427
to
d008d01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is a lot better than downgrading for Linux as well
@happysalada now that we have disabled SEEK_HOLE, would you be able to check if we can un-revert this on darwin? I would myself but I wasn't able to reproduce any of the darwin issues on my end. |
I'm referring to testing the go/rust issues we didn't notice originally, but you noticed on staging-next that resulted in this revert. I didn't encounter those myself but if you can confirm that they're no longer an issue, we can un-revert this, right? |
originally PR #143097 switched coreutils for darwin as well. I had tested the rust issuer with that PR. |
opened a PR, currently testing it |
This reverts coreutils upgrade just for darwin.
For more information see the details on #141684 (comment)
Motivation for this change
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)