Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging] coreutils: 8.32 -> 9.0 #139541

Merged
merged 2 commits into from
Oct 2, 2021
Merged

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Sep 26, 2021

Motivation for this change

This might speed up cp and mv in nix builds (on certain file systems) since the tools use copy_file_range now.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests) → I built the small channel on x86_64-linux
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@r-burns
Copy link
Contributor

r-burns commented Sep 26, 2021

@dasJ dasJ marked this pull request as ready for review September 26, 2021 17:39
@dasJ
Copy link
Member Author

dasJ commented Sep 26, 2021

Marking this as ready since a lot of relevant builds are succeeding on the systems I have easy access to (x86_64-linux, aarch64-linux).

I'm still building the entire nixos/release-small.nix for these systems but apart from unrelated eval errors, everything seems to be going well.
I will report back when the builds are done.

@r-burns
Copy link
Contributor

r-burns commented Sep 26, 2021

Cherry-picked 97c7af3f4dab4fb715b65786e3be5ac1b507618e (this PR) back to 7c86d10 (master).

Encountered during x86_64-darwin stdenv bootstrap: make[2]: *** No rule to make target '-lintl', needed by 'src/coreutils'. Stop.

@dasJ
Copy link
Member Author

dasJ commented Sep 26, 2021

@r-burns Fixed. Currently building stdenv on x86_64-darwin

Copy link
Contributor

@r-burns r-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, one very long rebuild later, darwin stdenv is building.

Also tested on x86_64-linux: stdenv, pkgsMusl.coreutils, pkgsStatic.coreutils, pkgsCross.aarch64-multiplatform.coreutils. Problematic leaf packages will probably need to be addressed individually in staging-next.

@dasJ
Copy link
Member Author

dasJ commented Sep 27, 2021

Still seems to fail on aarch64-linux while building coreutils in the checkPhase

FAIL: tests/tail-2/assert
=========================

x
==> a <==
x

==> foo <==
FAIL tests/tail-2/assert.sh (exit status: 1)

Test seems flaky on aarch64

@dasJ
Copy link
Member Author

dasJ commented Sep 27, 2021

This is probably good to go now. I was able to build:

  • The small channel on x86_64-linux
  • stdenv for x86_64-darwin
  • Parts of the small channel on aarch64 due to my limited computing resources on that platform. No builds failed, just most of them are still running. Succeeding are stdenv, gettext, and vim

@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Sep 30, 2021
@vcunat vcunat merged commit 11fe58c into NixOS:staging Oct 2, 2021
@ajs124 ajs124 deleted the upd/coreutils branch October 2, 2021 14:31
@r-burns
Copy link
Contributor

r-burns commented Oct 19, 2021

I noticed some Go packages were segfaulting in #141684, and the segfaults reproduce locally. I bisected the jx failure https://hydra.nixos.org/build/156019589 to this bump. Any ideas?

@vcunat
Copy link
Member

vcunat commented Oct 25, 2021

So... we revert this until someone manages to resolve these issues somehow (or they disappear with so further upstream update)? #141684 (comment)

@dasJ
Copy link
Member Author

dasJ commented Oct 25, 2021

I'll take a look at it and report back in the next couple of hours

@vcunat
Copy link
Member

vcunat commented Oct 25, 2021

For reference, reverted on *-darwin only in PR #142836

@vcunat vcunat mentioned this pull request Oct 25, 2021
10 tasks
@vcunat
Copy link
Member

vcunat commented Oct 25, 2021

And there's some Linux regression as well :-( #119110 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv This PR causes stdenv to rebuild 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants