Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RPC v0.8 now doesn't support broadcasted transaction less than v3 #2544

Merged
merged 4 commits into from
Feb 25, 2025

Conversation

AnkushinDaniil
Copy link
Contributor

This pull request includes several changes to fix the validation logic. The most important changes include removing redundant validator calls, updating validation rules for transaction fields, and adding a new custom validation function for versions.

@AnkushinDaniil AnkushinDaniil changed the title Fix validation Fix validation (does not support v0-2 in v0.8) Feb 24, 2025
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.61%. Comparing base (7239e37) to head (37dbd51).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
validator/validator.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2544      +/-   ##
==========================================
+ Coverage   73.57%   73.61%   +0.04%     
==========================================
  Files         137      137              
  Lines       16662    16659       -3     
==========================================
+ Hits        12259    12264       +5     
+ Misses       3537     3531       -6     
+ Partials      866      864       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rodrigo-pino rodrigo-pino requested a review from hudem1 February 25, 2025 08:22
@AnkushinDaniil AnkushinDaniil added the High priority Needs to be solved this week or the next label Feb 25, 2025
@AnkushinDaniil AnkushinDaniil changed the title Fix validation (does not support v0-2 in v0.8) fix: RPC v0.8 now doesn't support broadcasted transaction less than v3 Feb 25, 2025
@hudem1 hudem1 merged commit c8bd1d1 into main Feb 25, 2025
14 checks passed
@hudem1 hudem1 deleted the daniil/fix-rb-validation-v2 branch February 25, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High priority Needs to be solved this week or the next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants