Fix validation (supports v0-2 in v0.8) #2539
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2539 +/- ##
==========================================
+ Coverage 73.49% 73.51% +0.02%
==========================================
Files 136 136
Lines 16657 16661 +4
==========================================
+ Hits 12242 12249 +7
+ Misses 3547 3544 -3
Partials 868 868 ☔ View full report in Codecov by Sentry. |
Which issue? |
rodrigo-pino
approved these changes
Feb 24, 2025
Comment on lines
+26
to
34
|
|
||
| // Only enforce resource bounds validation for version 0x3 | ||
| if version == "0x3" || version == "0x100000000000000000000000000000003" { | ||
| return req.ResourceBounds != nil && len(*req.ResourceBounds) == 3 | ||
| } | ||
|
|
||
| // Allow earlier versions without resource bounds | ||
| return true | ||
| } |
There was a problem hiding this comment.
Nitpick: Return the condition instantly:
Suggested change
| // Only enforce resource bounds validation for version 0x3 | |
| if version == "0x3" || version == "0x100000000000000000000000000000003" { | |
| return req.ResourceBounds != nil && len(*req.ResourceBounds) == 3 | |
| } | |
| // Allow earlier versions without resource bounds | |
| return true | |
| } | |
| // Only enforce resource bounds validation for version 0x3 | |
| return version != "0x3" && version != "0x100000000000000000000000000000003" || | |
| (req.ResourceBounds != nil && len(*req.ResourceBounds) == 3) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue in which the
resource_bounds_requiredvalidation was misapplied to v0-2 transactions.