Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trie): implement new trie architecture with separated node types #2355

Open
wants to merge 54 commits into
base: weiihann/improve-state-trie
Choose a base branch
from

refactor: prepare for hashdb separation

3dca1e3
Select commit
Loading
Failed to load commit list.
Open

feat(trie): implement new trie architecture with separated node types #2355

refactor: prepare for hashdb separation
3dca1e3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 3, 2025 in 0s

73.36% (target 70.00%)

View this Pull Request on Codecov

73.36% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 71.99159% with 533 lines in your changes missing coverage. Please review.

Project coverage is 73.36%. Comparing base (f9b4aed) to head (3dca1e3).

Files with missing lines Patch % Lines
core/trie2/proof.go 69.16% 99 Missing and 37 partials ⚠️
core/trie2/trieutils/bitarray.go 74.48% 131 Missing and 4 partials ⚠️
core/trie2/trie.go 78.04% 69 Missing and 14 partials ⚠️
core/trie2/triedb/pathdb/database.go 50.51% 41 Missing and 7 partials ⚠️
core/trie2/node_enc.go 58.55% 31 Missing and 15 partials ⚠️
core/trie2/node.go 44.23% 29 Missing ⚠️
core/trie2/trienode/nodeset.go 72.22% 10 Missing and 5 partials ⚠️
core/trie2/id.go 20.00% 12 Missing ⚠️
core/trie2/hasher.go 86.66% 8 Missing and 2 partials ⚠️
utils/orderedset.go 0.00% 6 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@                       Coverage Diff                       @@
##           weiihann/improve-state-trie    #2355      +/-   ##
===============================================================
- Coverage                        73.61%   73.36%   -0.25%     
===============================================================
  Files                              136      150      +14     
  Lines                            16658    18561    +1903     
===============================================================
+ Hits                             12262    13617    +1355     
- Misses                            3535     3994     +459     
- Partials                           861      950      +89

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov