-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the spec #128
Update the spec #128
Conversation
Signed-off-by: Denis Varlakov <denis@dfns.co>
The spec was successfully compiled. PDF is available here. |
Benchmark ResultBenchmarks
|
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Denis Varlakov <denis@dfns.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few thoughts after having gone through aux gen protocol
Signed-off-by: Denis Varlakov <denis@dfns.co>
//! l: 4, | ||
//! epsilon: 128, | ||
//! l: 256, | ||
//! epsilon: 230, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: previous params set has failed on CI: https://github.com/LFDT-Lockness/cggmp21/actions/runs/12690901369/job/35372765003
Signed-off-by: Denis Varlakov <denis@dfns.co>
@maurges can you take a look before I start rewriting all proofs? |
Signed-off-by: Denis Varlakov <denis@dfns.co>
Signed-off-by: Denis Varlakov <denis@dfns.co>
Looks good, go ahead |
Signed-off-by: Denis Varlakov <denis@dfns.co>
Signed-off-by: Denis Varlakov <denis@dfns.co>
Signed-off-by: Denis Varlakov <denis@dfns.co>
Signed-off-by: Denis Varlakov <denis@dfns.co>
Signed-off-by: Denis Varlakov <denis@dfns.co>
Signed-off-by: Denis Varlakov <denis@dfns.co>
Signed-off-by: Denis Varlakov <denis@dfns.co>
Signed-off-by: Denis Varlakov <denis@dfns.co>
Can you check this out? @maurges I've updated all proofs, next I want to update the protocol specs, so they also use Overall, there's no significant changes, I just unified notation, and sometimes rearranged order of arguments. I also reviewed again all ZK proofs implementations to be aligned with the spec, all looks good. |
Signed-off-by: Denis Varlakov <denis@dfns.co>
Signed-off-by: Denis Varlakov <denis@dfns.co>
@maurges the final touch: I updated all protocols to use |
well, not counting automatic formatting, but turns out that easier to migrate to typst... |
Signed-off-by: Denis Varlakov <denis@dfns.co>
(@maurges it's ready for the final review) |
Signed-off-by: Denis Varlakov <denis@dfns.co>
Looks good. I'd like to have one rephrasing in discussion here #128 (review) and that's it |
Signed-off-by: Denis Varlakov <denis@dfns.co>
The spec is currently in state of chaos:
main.tex
is poorly formatted as several people were writing and rewriting it with different style preferences. E.g. different part of the spec use 2 space indent, while others use 4 spaceThe idea of this PR is to update the spec sources to have uniform formatting, make sources easier to read, preferably use a formatting tool and integrate it into CI. Also, unify notations and sync specs and the code where they are not synced.
In addition to that, I also want to make types of the messages received during the protocols explicit, e.g.
which explicitly says that the implementation does need to check that we received integer in$\mathbb F_q$ .
Progress: