Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implementation of dlog with el gamal commitment zkp #131

Open
wants to merge 1 commit into
base: cggmp24/m
Choose a base branch
from

Conversation

manel1874
Copy link

@manel1874 manel1874 commented Jan 20, 2025

Implementation of Discrete Log with El-Gamal commitment ZK, called $\prod^{elog}$ in the new cggmp24 version.

Motivation

This is part of the ongoing effort to update the cggmp21 implementetion to the latest version. Changes required within the zkps:

New protocols to be implemented:

Protocols to be changed

Protocols no longer used (to be deleted)

  • Paillier Encryption in Range ZK $\prod^{enc}$

@survived
Copy link
Contributor

survived commented Jan 21, 2025

Hey @manel1874, thanks for submitting the proofs! Note that we also require all contributors to sign-off commits: it's a requirement from Linux Foundation. See pipeline fail message

Also we will need that you update the spec with descriptions of the proof, but please don't do that yet, as we're in the process of refactoring the spec in #128

@manel1874 manel1874 force-pushed the feat/dlog-with-el-gamal-commitment branch from 448b59f to 705d5b7 Compare January 22, 2025 10:03
@manel1874
Copy link
Author

manel1874 commented Jan 22, 2025

See pipeline fail message

Done, thanks! I thought committing with -s flag would be enough. I changed all other three PRs as well.

Co-authored-by: jfdreis <josevtnreis@gmail.com>
Signed-off-by: manel1874 <manel1874@gmail.com>
@manel1874 manel1874 force-pushed the feat/dlog-with-el-gamal-commitment branch from 705d5b7 to 7d32539 Compare January 25, 2025 13:51
@manel1874
Copy link
Author

Not sure what the pipeline error means:

Run marocchino/sticky-pull-request-comment@v2
Error: Resource not accessible by integration

@survived
Copy link
Contributor

survived commented Jan 27, 2025

It's a pipeline that writes a comment on the PR page, probably it doesn't like being triggered from outside. We can safely ignore it.

@survived
Copy link
Contributor

Hi @manel1874, #128 is merged, can you merge cggmp24/m into your branches and update the specs to document new proofs?

I'm going to be off the next week, if you need assistance, feel free to ping @maurges

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants