Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI android - add new options #72

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/workflows/build_android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,11 @@ jobs:
env:
DATA: ${{ secrets.GOOGLESERVICES }}
run: echo $DATA > /home/runner/work/pola-flutter/pola-flutter/android/app/google-services.json
# - name: Check formatting
# run: flutter format --set-exit-if-changed #not working in my computer
- name: Statically analyze
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proponuję dodać odpowiednie zmiany w .github/workflows/tests.yml.
Workflow build_android/ios zostawiłbym tylko na sprawdzenie czy apka buduje się na daną platformę. Wszystkie lintery, testy czy formattery które sprawdzają kod flutterowy do workflow tests. Można zmienić mu nazwę by było to bardziej czytelne.

run: flutter analyze
- name: Widget tests
run: flutter test
- name: Build apk
run: flutter build apk --debug
# - uses: "finnp/create-file-action@master" this step doesn't work
# env:
# FILE_NAME: "/home/runner/work/pola-flutter/pola-flutter/android/app/google-services.json"
# FILE_BASE64: ${{ secrets.GOOGLESERVICES }}
# - run: flutter build apk --debug
3 changes: 2 additions & 1 deletion lib/pages/scan/companies_list.dart
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ class CompaniesList extends StatelessWidget {
),
),
),
RemoteButton(RemoteButtonState(state.list.first.donate, state.list.first.code))
RemoteButton(RemoteButtonState(
state.list.firstOrNull?.donate, state.list.firstOrNull?.code))
]);
}

Expand Down
Loading