CI android - add new options #72
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WezSieTato
requested changes
Mar 13, 2024
.github/workflows/build_android.yml
Outdated
| @@ -27,10 +27,11 @@ jobs: | |||
| env: | |||
| DATA: ${{ secrets.GOOGLESERVICES }} | |||
| run: echo $DATA > /home/runner/work/pola-flutter/pola-flutter/android/app/google-services.json | |||
| # - name: Check formatting | |||
| # run: flutter format --set-exit-if-changed #not working in my computer | |||
| - name: Statically analyze | |||
There was a problem hiding this comment.
Proponuję dodać odpowiednie zmiany w .github/workflows/tests.yml.
Workflow build_android/ios zostawiłbym tylko na sprawdzenie czy apka buduje się na daną platformę. Wszystkie lintery, testy czy formattery które sprawdzają kod flutterowy do workflow tests. Można zmienić mu nazwę by było to bardziej czytelne.
|
Zamykam. Statyczna analiza jest dodana do workflow tests. Jeśli chodzi o formatowanie to ogarnie się to w trakcie lub po redesignie. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Options in CI for android