feature/80-i18next-implementation #84

JanJaroszczak · 2024-01-29T08:40:20Z

Implementation of i18next

Strings in JSX (in this case called 'translations') are now managed by react-i18next library
All English translations are located in en.ts file (src/translations/locales/en.ts) and they are arranged alphabetically

My changes generate no new warnings
My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the changelog
I have added tests that prove my fix is effective or that my feature works

remove concept app environment

Multiple app windows wallet fixes

…nsate-for-node-and-db-sync-repository-url-changes update urls to docker images, update repo owner condition

`cardano-db-sync` got a new version `sancho-3-0-0` which brings some breaking changes. This commit updates the SQL queries where needed.

…-bump chore: bumped cardano node and db-sync versions

…or-db-sync-sancho-3-0-0 [57] Update SQL queries for sancho-3-0-0

…twork/metrics endpoint Before there was no easy way to check current voting power of alwaysAbstain and noConfidence dreps. Now they are available in the network/metrics endpoint

…d-noconfidence-dreps-voting-power-to-the-networkmetrics [64] feat: add alwaysAbstain and noConfidence voting powers to the ne…

…deploy to force resync

Tool to recreate Cardano node/db/db-sync

docs rewrite working conventions

#27 add basic auth for dev/test environments

Votes were counted in a wrong way, especially when it came to NoConfidence GAs and AlwaysNoConfidence DRep. The SQL query was modified and the problem is fixed

…oting-power [59] Fixed vote counting problem

MSzalowski

This type of changes - from strings to variables is almost impossible to review due to its size.

And here - perfect fit would be snapshot testing to just check via snapshots what has changed - if anything changes.

Just a suggestion - wdyt of integrating the snapshots testing to your testing pr?

src/vva-fe/src/translations/usei18n.ts

Ryun1 · 2024-01-29T13:35:36Z

Please use the PR template 🙏

MSzalowski · 2024-01-30T11:07:41Z

@JanJaroszczak TODO:

Change PR description to follow the template
Remove usei18n hook in favor of useTranslation due to changes delivered with 6c7a57a0e64a3dde3c8cf82af09ccab648e42f5a
Remove any types related code as they are no longer required.

And additionally as I made an export of useTranslation from hooks, could you please also update an import in src/vva-fe/src/components/atoms/CopyButton.tsx to import useTranslation from hooks instead of react-i18next?
I should have done it, but I missed that 😅

MSzalowski · 2024-01-30T13:51:38Z

src/vva-fe/src/components/organisms/DashboardCards.tsx

@@ -284,16 +285,16 @@ export const DashboardCards = () => {
            delegateTransaction?.transactionHash


Suggested change

delegateTransaction?.transactionHash

t(delegateTransaction?.transactionHash ? "dashboard.delegation.changeDelegation" : "delegate")

won't we miss the variant with empty string from line 286?

Right, it should be based on currentDelegation

MSzalowski · 2024-01-30T13:52:21Z

src/vva-fe/src/components/molecules/GovernanceActionCard.tsx

@@ -237,7 +237,9 @@ export const GovernanceActionCard: FC<ActionTypeProps> = ({ ...props }) => {
          }}
          data-testid={`govaction-${govActionId}-view-detail`}
        >
-          {inProgress ? "See transaction" : "View proposal details"}
+          {inProgress
+            ? t("seeTransaction")


Suggested change

? t("seeTransaction")

? t(inProgress ? "seeTransaction" : "govActions.viewProposalDetails")

MSzalowski · 2024-01-30T13:55:26Z

src/vva-fe/src/components/molecules/GovernanceVotedOnCard.tsx

@@ -119,7 +119,7 @@ export const GovernanceVotedOnCard = ({ votedProposal, inProgress }: Props) => {
        </Box>
        <Box mt={5}>
          <Typography color={"#8E908E"} variant="caption">
-            Governance Action ID:
+            {t("govActions.id")}


I would call that keys:

... "govActions": { ..., "governanceActionType": "Governance Action Type:", "governanceActionId": "Governance Action ID:", ..., }, ...

Looks a bit more clear to me

MSzalowski · 2024-01-30T13:57:16Z

src/vva-fe/src/components/molecules/VoteActionForm.tsx

@@ -201,15 +204,15 @@ export const VoteActionForm = ({
              dataTestId="url-input"
              errorMessage={errors.url?.message}
              formFieldName="url"
-              placeholder="Your URL with with your context"
+              placeholder={t("forms.urlWithContextPlaceholder")}
              width={"100%"}


Additionally remove curly braces around string prop here and below. For the consistency & code cleanup 💅

MSzalowski · 2024-01-30T14:16:45Z

src/vva-fe/src/components/organisms/DashboardCards.tsx

-              : "If you want to directly participate in voting and have other ada holders delegate their voting power to you."
-          }
+          description={t(
+            `dashboard.registration.${


Can we go with a switch/case statement instead of a ternary? Those nested ternaries are almost unreadable

MSzalowski · 2024-01-30T14:23:02Z

src/vva-fe/src/components/organisms/ExternalLinkModal.tsx

@@ -26,13 +27,15 @@ export function ExternalLinkModal() {
        style={{ height: "84px", margin: "0 auto", width: "84px" }}
      />
      <ModalHeader sx={{ marginTop: "34px" }}>
-        {isMobile ? "External Link Safety" : "Be Careful!"}
+        {isMobile
+          ? t("modals.externalLink.safety")


Put ternary inside function parameter

MSzalowski · 2024-01-30T14:23:15Z

src/vva-fe/src/components/organisms/ExternalLinkModal.tsx

@@ -79,7 +80,7 @@ export function ExternalLinkModal() {
          }}
          variant="contained"
        >
-          {isMobile ? "Continue" : "Continue to external link"}
+          {isMobile ? t("continue") : t("modals.externalLink.continueTo")}


Same as above

src/vva-fe/src/components/organisms/Hero.tsx

MSzalowski · 2024-01-30T14:26:24Z

src/vva-fe/src/context/wallet.tsx

                : registerTransaction.type === "registration"
-                ? "Registration transaction failed"
-                : "Update DRep metadata transaction failed"
+                ? t("alerts.registration.failed")


ternary inside parameter

MSzalowski · 2024-01-30T14:27:25Z

src/vva-fe/src/context/wallet.tsx

-            console.log(
-              "Warning, no registered stake keys, using unregistered stake keys"
-            );
+            console.log(t("warnings.usingUnregisteredStakeKeys"));


if warning shouldn't it be console.warn?

I can change it here, but if so - should we then change each similar case in the code from log to warn?

Then I guess it would be better to put this action into a separate task

MSzalowski · 2024-01-31T08:35:51Z

@JanJaroszczak Can you rebase that branch to develop?

Based on development process instruction.

MSzalowski · 2024-02-02T08:11:18Z

Closed in favor of #102

adgud and others added 30 commits December 19, 2023 07:23

remove concept app environment

f7a58ca

Merge pull request #40 from IntersectMBO/remove-concept

5d3e614

remove concept app environment

Multiple app windows wallet fixes

70ea02b

Commit verification test

ee922dd

Merge pull request #54 from IntersectMBO/wallet-bug-fix

9d2469b

Multiple app windows wallet fixes

update urls to docker images, update repo owner condition

23e4aeb

Merge pull request #61 from IntersectMBO/56-update-workflows-to-compe…

f66591a

…nsate-for-node-and-db-sync-repository-url-changes update urls to docker images, update repo owner condition

[57] Update SQL queries for sancho-3-0-0

8e0e43c

`cardano-db-sync` got a new version `sancho-3-0-0` which brings some breaking changes. This commit updates the SQL queries where needed.

chore: bumped cardano node and db-sync versions

d0a35a9

Merge pull request #65 from IntersectMBO/chore/63-node-dbsync-version…

78d5c9b

…-bump chore: bumped cardano node and db-sync versions

Merge pull request #62 from IntersectMBO/chore/57-update-be-queries-f…

57e0109

…or-db-sync-sancho-3-0-0 [57] Update SQL queries for sancho-3-0-0

[64] feat: add alwaysAbstain and noConfidence voting powers to the ne…

d90d8ae

…twork/metrics endpoint Before there was no easy way to check current voting power of alwaysAbstain and noConfidence dreps. Now they are available in the network/metrics endpoint

Merge pull request #66 from IntersectMBO/feat/64-add-alwaysabstain-an…

defa850

…d-noconfidence-dreps-voting-power-to-the-networkmetrics [64] feat: add alwaysAbstain and noConfidence voting powers to the ne…

add optional CI step to destroy cardano node and db sync data before …

38eeff4

…deploy to force resync

Merge pull request #70 from IntersectMBO/69-tool-to-resync

56e8008

Tool to recreate Cardano node/db/db-sync

docs rewrite working conventions

dfeee53

docs: adjusted changelog

1430fc3

docs: added PO and tech lead working conventions

5a80edb

docs: fix contributing contents table

30ca970

rough node upgrade info

34175cc

Merge pull request #26 from IntersectMBO/docs/update-working-conventions

213f5c2

docs rewrite working conventions

add basic auth for dev/test environments

8e34ce6

Merge pull request #71 from IntersectMBO/27-basic-auth

933526c

#27 add basic auth for dev/test environments

fix for prepare-config makefile invocation in actions

c31401d

export DOMAIN variable in actions

b6cf8d9

export NGINX_BASIC_AUTH var in actions

6d04d67

fix for basic auth exclusion

0a49daf

[59] Fixed vote counting problem

9fcfeaf

Votes were counted in a wrong way, especially when it came to NoConfidence GAs and AlwaysNoConfidence DRep. The SQL query was modified and the problem is fixed

Merge pull request #74 from IntersectMBO/fix/59-fix-predefined-drep-v…

cfe2b2b

…oting-power [59] Fixed vote counting problem

feature/80-i18next-implementation

1dd0154

JanJaroszczak requested a review from MSzalowski January 29, 2024 08:40

JanJaroszczak requested review from Sworzen1 and kickloop as code owners January 29, 2024 08:40

JanJaroszczak linked an issue Jan 29, 2024 that may be closed by this pull request

Implementing i18next #80

Closed

MSzalowski reviewed Jan 29, 2024

View reviewed changes

src/vva-fe/src/translations/usei18n.ts Outdated Show resolved Hide resolved

src/vva-fe/src/translations/usei18n.ts Outdated Show resolved Hide resolved

MSzalowski mentioned this pull request Jan 29, 2024

Snapshot testing #86

Closed

MSzalowski mentioned this pull request Jan 30, 2024

Breadcrumb text incorrect on disconnected GA detail page [BT-PO decision type, priority] #10

Closed

feat: provide i18next module typing

6c7a57a

MSzalowski force-pushed the 80-i18next-implementation branch from 722ec46 to 6c7a57a Compare January 30, 2024 11:03

JanJaroszczak added 2 commits January 30, 2024 13:20

feat: adjust i18next usage to new way of typing

b5eda1a

Changelog update

ab71a69

JanJaroszczak requested a review from Ryun1 as a code owner January 30, 2024 12:40

Changelog fix

0d69bb9

MSzalowski requested changes Jan 30, 2024

View reviewed changes

Further fixes after CR

5190a6f

MSzalowski changed the base branch from main to develop February 1, 2024 10:20

MSzalowski requested review from adgud and placek as code owners February 1, 2024 10:20

MSzalowski closed this Feb 2, 2024

MSzalowski deleted the 80-i18next-implementation branch February 16, 2024 12:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature/80-i18next-implementation #84

feature/80-i18next-implementation #84

JanJaroszczak commented Jan 29, 2024 •

edited by MSzalowski

Loading

MSzalowski left a comment

Ryun1 commented Jan 29, 2024

MSzalowski commented Jan 30, 2024

MSzalowski Jan 30, 2024

JanJaroszczak Jan 31, 2024

MSzalowski Jan 31, 2024

MSzalowski Jan 30, 2024

MSzalowski Jan 30, 2024

MSzalowski Jan 30, 2024

MSzalowski Jan 30, 2024

MSzalowski Jan 30, 2024

MSzalowski Jan 30, 2024

MSzalowski Jan 30, 2024

MSzalowski Jan 30, 2024

JanJaroszczak Jan 30, 2024

MSzalowski Jan 31, 2024

JanJaroszczak Jan 31, 2024

MSzalowski commented Jan 31, 2024

MSzalowski commented Feb 2, 2024

		@@ -284,16 +285,16 @@ export const DashboardCards = () => {
		delegateTransaction?.transactionHash

	delegateTransaction?.transactionHash
	t(delegateTransaction?.transactionHash ? "dashboard.delegation.changeDelegation" : "delegate")

	? t("seeTransaction")
	? t(inProgress ? "seeTransaction" : "govActions.viewProposalDetails")

feature/80-i18next-implementation #84

feature/80-i18next-implementation #84

Conversation

JanJaroszczak commented Jan 29, 2024 • edited by MSzalowski Loading

MSzalowski left a comment

Choose a reason for hiding this comment

Ryun1 commented Jan 29, 2024

MSzalowski commented Jan 30, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MSzalowski commented Jan 31, 2024

MSzalowski commented Feb 2, 2024

JanJaroszczak commented Jan 29, 2024 •

edited by MSzalowski

Loading