Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumb text incorrect on disconnected GA detail page [BT-PO decision type, priority] #10

Closed
l-br1 opened this issue Dec 14, 2023 · 5 comments
Assignees

Comments

@l-br1
Copy link

l-br1 commented Dec 14, 2023

from Mike S.

Description
To reproduce:

As a user without a connected wallet

Go to Governance Actions

Choose an Actions

Click “View Proposal details”

Issue: the breadcrumb text says “Vote on Governance Action” This is incorrect for two reasons, one is that there isn’t a wallet connected, and secondly, the breadcrumb should show the full path to the specifically-chosen action. I.e. something like Dashboard/Governance Actions/ or in beta

Environment

https://dev-sanchonet.govtool.byron.network

Wallet v 1.5.3


Image

@l-br1 l-br1 self-assigned this Dec 14, 2023
@Thomas-Upfield
Copy link

@m-i-k-e I am adding this to the TO DO pile.

@MSzalowski
Copy link
Contributor

To be done after #84

@Sworzen1
Copy link
Contributor

Sworzen1 commented Feb 1, 2024

@m-i-k-e If I understand correctly, you want to have breadcrumbs like: (Goverance Actions | 1dc054a4db56ac322d3772180e38059cdcf3f1927d5b0c366f0908f13b1e226a#2). Should at second place be full (like hash + id) or shortened version (760f...20c4#0) or maybe something else ?

@m-i-k-e
Copy link

m-i-k-e commented Feb 12, 2024

The original issue was that the user was not logged in, so they should not have the option to vote. However, this can be fixed for all users by changing the text "Vote on Governance Action" to the name of the Governance Action. Strangely, there is no name of this GA on the page at all.

As there is no "Governance Action Name" in the main panel. @Thomas-Upfield @l-br1 Can you please comment on why this is missing?.

@l-br1 l-br1 added this to Govtool all Apr 2, 2024
@l-br1 l-br1 moved this to Backlog in Govtool all Apr 2, 2024
@MSzalowski
Copy link
Contributor

It has been done the way @m-i-k-e has described in the last comment.

@github-project-automation github-project-automation bot moved this from Backlog to Done in Govtool all Apr 8, 2024
@MSzalowski MSzalowski moved this from Done to In staging in Govtool all Apr 8, 2024
@bosko-m bosko-m moved this from In staging to Done in Govtool all Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

6 participants