-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breadcrumb text incorrect on disconnected GA detail page [BT-PO decision type, priority] #10
Comments
@m-i-k-e I am adding this to the TO DO pile. |
To be done after #84 |
@m-i-k-e If I understand correctly, you want to have breadcrumbs like: (Goverance Actions | 1dc054a4db56ac322d3772180e38059cdcf3f1927d5b0c366f0908f13b1e226a#2). Should at second place be full (like hash + id) or shortened version (760f...20c4#0) or maybe something else ? |
The original issue was that the user was not logged in, so they should not have the option to vote. However, this can be fixed for all users by changing the text "Vote on Governance Action" to the name of the Governance Action. Strangely, there is no name of this GA on the page at all. As there is no "Governance Action Name" in the main panel. @Thomas-Upfield @l-br1 Can you please comment on why this is missing?. |
It has been done the way @m-i-k-e has described in the last comment. |
from Mike S.
Description
To reproduce:
As a user without a connected wallet
Go to Governance Actions
Choose an Actions
Click “View Proposal details”
Issue: the breadcrumb text says “Vote on Governance Action” This is incorrect for two reasons, one is that there isn’t a wallet connected, and secondly, the breadcrumb should show the full path to the specifically-chosen action. I.e. something like Dashboard/Governance Actions/ or in beta
Environment
https://dev-sanchonet.govtool.byron.network
Wallet v 1.5.3
The text was updated successfully, but these errors were encountered: