Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

38 profile page editing #147

Merged
merged 22 commits into from
May 8, 2024
Merged

38 profile page editing #147

merged 22 commits into from
May 8, 2024

Conversation

andrewzpu
Copy link
Contributor

@andrewzpu andrewzpu commented Apr 8, 2024

Added edit profile page which allows users to edit and update preferred name, major, degree, graduation year, and car.
Includes new frontend page and backend post route to update database

@ryanyychen ryanyychen linked an issue Apr 8, 2024 that may be closed by this pull request
4 tasks
Copy link
Contributor

@ryanyychen ryanyychen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When opening the profile edit page when 'Other' for Major or Degree is selected, the default selected should be 'Other' and what they have there should be entered.

@ryanyychen ryanyychen added feature Build in something new priority:medium labels Apr 9, 2024
Copy link
Contributor

@ryanyychen ryanyychen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default major/degree selection behavior:

  • When user has a major (not other), then the default value selected should be their major. Switching to Other should prompt an empty textbox.
  • When user has 'Other' originally, then the default value selected should be 'Other' and their major should be filled in in textbox.

Other features to add:

  • Keep display of sidebar/navbar so that the page looks like rest of portal
  • Attempts to navigate away from the page should prompt a confirmation message
  • Add in cancel button that returns user to profile page

Copy link
Contributor

@ryanyychen ryanyychen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add:

Attempts to navigate away from the page should prompt a confirmation message if anything has been changed
Add in cancel button that returns user to profile page

Copy link
Contributor

@ryanyychen ryanyychen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on implementing the cancel button! Thanks Andrew.

One more thing to add: could you have the leave page confirmation pop up not just when they click on the cancel button but also any attempts to leave or refresh the page?

Copy link
Contributor

@ryanyychen ryanyychen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing the change quickly. The save and cancel buttons do not seem to be clickable anymore...

Copy link
Contributor

@ryanyychen ryanyychen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

@ryanyychen ryanyychen merged commit cd7cf00 into master May 8, 2024
3 checks passed
@ryanyychen ryanyychen deleted the 38-profile-page-editing branch May 8, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Build in something new priority:medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile Page Changes
2 participants