-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
38 profile page editing #147
Conversation
…/hkn-portal into 38-profile-page-editing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When opening the profile edit page when 'Other' for Major or Degree is selected, the default selected should be 'Other' and what they have there should be entered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default major/degree selection behavior:
- When user has a major (not other), then the default value selected should be their major. Switching to Other should prompt an empty textbox.
- When user has 'Other' originally, then the default value selected should be 'Other' and their major should be filled in in textbox.
Other features to add:
- Keep display of sidebar/navbar so that the page looks like rest of portal
- Attempts to navigate away from the page should prompt a confirmation message
- Add in cancel button that returns user to profile page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add:
Attempts to navigate away from the page should prompt a confirmation message if anything has been changed
Add in cancel button that returns user to profile page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on implementing the cancel button! Thanks Andrew.
One more thing to add: could you have the leave page confirmation pop up not just when they click on the cancel button but also any attempts to leave or refresh the page?
…(ie reload, closing, etc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pushing the change quickly. The save and cancel buttons do not seem to be clickable anymore...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks!
Added edit profile page which allows users to edit and update preferred name, major, degree, graduation year, and car.
Includes new frontend page and backend post route to update database