-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install Daft on existing Kubernetes cluster and submit jobs using daft-launcher #44
Conversation
…r, and support BYOC k8s clusters in daft-launcher Added docs for kuberay + daft installation, fixed minor linter issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, but there are some configuration file changes that I think we should look over.
Also, I noticed that your editor removes the newlines (\n
) from the end of the file. If you don't mind, could you try to keep them in? It usually is stylistic best practice to keep them in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Support Daft on Kubernetes
This PR introduces support for Daft on existing Kubernetes clusters (BYOC - Bring Your Own Cluster) and improves documentation around cluster setup and SSH configuration.
Major Changes
1. Kubernetes Setup Documentation
2. CLI Enhancements & Command Support
Current command support matrix:
3. SSH Key Setup Documentation
Added instructions for SSH key setup in the README. Would appreciate review on:
daft up
Questions for Reviewers
Provider Naming:
aws
vsk8s
managed
vsbyoc
ormanaged
vsk8s
Command Structure:
daft up
(fails for k8s with "not supported" message)daft aws up
/daft k8s submit
Testing Done
init
andsubmit
(will hold off on verifying the rest until after the high level approach detailed in this PR has been approved).Next Steps