Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cleanup Kubernetes PR and add tests #47

Merged
merged 16 commits into from
Jan 24, 2025
Merged

chore: Cleanup Kubernetes PR and add tests #47

merged 16 commits into from
Jan 24, 2025

Conversation

raunakab
Copy link
Contributor

@raunakab raunakab commented Jan 23, 2025

Overview

This PR aims to address some changes introduced in this PR.

Changes:

  • Fix tests
  • Add more tests
  • Update configuration file structure
  • Update CLI interface

jessie-young and others added 4 commits January 19, 2025 19:55
@raunakab raunakab requested a review from jessie-young January 23, 2025 01:44
jessie-young
jessie-young previously approved these changes Jan 23, 2025
Base automatically changed from k8s to master January 23, 2025 05:42
@raunakab raunakab dismissed jessie-young’s stale review January 23, 2025 05:42

The base branch was changed.

@raunakab raunakab changed the title Address some changes with the PR chore: Cleanup Kubernetes PR and add tests Jan 23, 2025
@raunakab raunakab requested a review from jessie-young January 23, 2025 06:04
@raunakab raunakab marked this pull request as draft January 23, 2025 06:07
jessie-young
jessie-young previously approved these changes Jan 23, 2025
@raunakab raunakab marked this pull request as ready for review January 23, 2025 06:23
@raunakab raunakab requested a review from jessie-young January 23, 2025 06:23
Copy link
Collaborator

@jessie-young jessie-young left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One one minor comment but otherwise looks good

@jessie-young jessie-young merged commit 1530f6d into master Jan 24, 2025
1 check passed
@jessie-young jessie-young deleted the k8s-fixes branch January 24, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants