Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: window logical plan #3920

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
+1,541 −26

fix(tests): correct pytest skip decorator in window tests

f7aa71d
Select commit
Loading
Failed to load commit list.
Draft

fix: window logical plan #3920

fix(tests): correct pytest skip decorator in window tests
f7aa71d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Mar 6, 2025 in 1s

17.27% of diff hit (target 78.46%)

View this Pull Request on Codecov

17.27% of diff hit (target 78.46%)

Annotations

Check warning on line 138 in daft/__init__.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/__init__.py#L138 

Added line #L138 was not covered by tests

Check warning on line 57 in daft/expressions/expressions.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/expressions/expressions.py#L57 

Added line #L57 was not covered by tests

Check warning on line 60 in daft/expressions/expressions.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/expressions/expressions.py#L60 

Added line #L60 was not covered by tests

Check warning on line 67 in daft/expressions/expressions.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/expressions/expressions.py#L62-L67 

Added lines #L62 - L67 were not covered by tests

Check warning on line 69 in daft/expressions/expressions.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/expressions/expressions.py#L69 

Added line #L69 was not covered by tests

Check warning on line 71 in daft/expressions/expressions.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/expressions/expressions.py#L71 

Added line #L71 was not covered by tests

Check warning on line 73 in daft/expressions/expressions.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/expressions/expressions.py#L73 

Added line #L73 was not covered by tests

Check warning on line 75 in daft/expressions/expressions.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/expressions/expressions.py#L75 

Added line #L75 was not covered by tests

Check warning on line 77 in daft/expressions/expressions.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/expressions/expressions.py#L77 

Added line #L77 was not covered by tests

Check warning on line 80 in daft/expressions/expressions.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/expressions/expressions.py#L79-L80 

Added lines #L79 - L80 were not covered by tests

Check warning on line 1514 in daft/expressions/expressions.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/expressions/expressions.py#L1514 

Added line #L1514 was not covered by tests

Check warning on line 1540 in daft/expressions/expressions.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/expressions/expressions.py#L1540 

Added line #L1540 was not covered by tests

Check warning on line 1551 in daft/expressions/expressions.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/expressions/expressions.py#L1551 

Added line #L1551 was not covered by tests

Check warning on line 1562 in daft/expressions/expressions.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/expressions/expressions.py#L1562 

Added line #L1562 was not covered by tests

Check warning on line 1573 in daft/expressions/expressions.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/expressions/expressions.py#L1573 

Added line #L1573 was not covered by tests

Check warning on line 1584 in daft/expressions/expressions.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/expressions/expressions.py#L1584 

Added line #L1584 was not covered by tests

Check warning on line 1598 in daft/expressions/expressions.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/expressions/expressions.py#L1598 

Added line #L1598 was not covered by tests

Check warning on line 1610 in daft/expressions/expressions.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/expressions/expressions.py#L1610 

Added line #L1610 was not covered by tests

Check warning on line 26 in daft/window.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/window.py#L26 

Added line #L26 was not covered by tests

Check warning on line 42 in daft/window.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/window.py#L41-L42 

Added lines #L41 - L42 were not covered by tests

Check warning on line 48 in daft/window.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/window.py#L45-L48 

Added lines #L45 - L48 were not covered by tests

Check warning on line 50 in daft/window.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/window.py#L50 

Added line #L50 was not covered by tests

Check warning on line 55 in daft/window.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/window.py#L53-L55 

Added lines #L53 - L55 were not covered by tests

Check warning on line 72 in daft/window.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/window.py#L69-L72 

Added lines #L69 - L72 were not covered by tests

Check warning on line 74 in daft/window.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/window.py#L74 

Added line #L74 was not covered by tests
View more details on Codecov