fix: window logical plan

[f4t4nt]

Some more work towards implementing window functions for test_basic.py, unclear where gap in my understanding is - keep getting unexpected errors when running tests

[codspeed-hq]

CodSpeed Performance Report

Merging #3920 will degrade performances by 16.21%

_{Comparing fix/window-logical-plan (f7aa71d) with main (dfc1b08)}

Summary

❌ 1 regressions
✅ 23 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
❌	test_tpch_sql[1-in-memory-native-8]	123.4 ms	147.3 ms	-16.21%

[codecov]

Codecov Report

Attention: Patch coverage is 17.27749% with 632 lines in your changes missing coverage. Please review.

Project coverage is 78.07%. Comparing base (567ae9a) to head (f7aa71d).
Report is 25 commits behind head on main.

Files with missing lines	Patch %	Lines
...n/src/optimization/rules/detect_window_function.rs	26.62%	113 Missing ⚠️
src/daft-logical-plan/src/ops/window.rs	0.00%	108 Missing ⚠️
src/daft-dsl/src/python.rs	5.68%	83 Missing ⚠️
src/daft-dsl/src/expr/window.rs	0.00%	71 Missing ⚠️
src/daft-local-execution/src/pipeline.rs	0.00%	45 Missing ⚠️
daft/window.py	35.29%	33 Missing ⚠️
src/daft-dsl/src/functions/window/mod.rs	0.00%	30 Missing ⚠️
src/daft-functions/src/window/mod.rs	0.00%	30 Missing ⚠️
daft/expressions/expressions.py	55.76%	23 Missing ⚠️
src/daft-logical-plan/src/logical_plan.rs	11.53%	23 Missing ⚠️
... and 9 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3920      +/-   ##
==========================================
- Coverage   78.46%   78.07%   -0.40%     
==========================================
  Files         767      775       +8     
  Lines       97108    98732    +1624     
==========================================
+ Hits        76193    77081     +888     
- Misses      20915    21651     +736     

Files with missing lines	Coverage Δ
src/daft-dsl/src/lib.rs	100.00% <100.00%> (ø)
src/daft-functions/src/lib.rs	0.00% <ø> (ø)
src/daft-functions/src/python/mod.rs	100.00% <100.00%> (ø)
...rc/daft-logical-plan/src/optimization/optimizer.rs	95.48% <100.00%> (+0.01%)	⬆️
daft/__init__.py	18.00% <0.00%> (-5.08%)	⬇️
src/daft-dsl/src/functions/mod.rs	79.66% <0.00%> (-1.38%)	⬇️
...lan/src/optimization/rules/push_down_projection.rs	93.65% <92.30%> (-0.10%)	⬇️
src/daft-dsl/src/expr/mod.rs	78.83% <75.00%> (-0.12%)	⬇️
...cal-plan/src/optimization/rules/unnest_subquery.rs	88.68% <0.00%> (-0.91%)	⬇️
src/daft-functions/src/python/window.rs	0.00% <0.00%> (ø)
... and 13 more

... and 195 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.