-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AN-385] Move listRuntimes over to new Sam permissions model - take 2 #4827
Conversation
…ons mode…" This reverts commit 9cdf0d0.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4827 +/- ##
===========================================
- Coverage 74.77% 74.59% -0.18%
===========================================
Files 166 166
Lines 14800 14609 -191
Branches 1112 1101 -11
===========================================
- Hits 11067 10898 -169
+ Misses 3733 3711 -22
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Testing is looking good on my BEE. Kicking the automation test again as ArgoCd has been a bit buggy today. Should be good for a final review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basic testing on BEE looked good
Reverts #4823
JIRA ticket: https://broadworkbench.atlassian.net/browse/AN-385
This change was originally reverted, because it removed the ability to list deleted runtimes, which AOU RWB was making use of. See https://docs.google.com/document/d/1uivQxiSoFAyD7vpmFxes5037Dn1m0yx8VovsonylKYw/edit?tab=t.0#heading=h.mf724qma605n
Now that we confirmed that RWB can default to default settings instead of the user’s prior configurations, we can move forward with this PR again, with some added modifications to the swagger page to deprecate the
includeDeleted
flag.