-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AN-385] new sam disk permissions #4828
[AN-385] new sam disk permissions #4828
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## revert-4823-mtalbott-revert-listRuntimes #4828 +/- ##
============================================================================
- Coverage 74.62% 74.57% -0.05%
============================================================================
Files 166 166
Lines 14685 14609 -76
Branches 1164 1101 -63
============================================================================
- Hits 10959 10895 -64
+ Misses 3726 3714 -12
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
431b9c3
into
revert-4823-mtalbott-revert-listRuntimes
Jira ticket: https://broadworkbench.atlassian.net/browse/AN-385
Summary of changes
What
includeDeleted
query parameter now that our get disk endpoint won't be able to return deleted disksWhy
revert-4823-mtalbott-revert-listRuntimes
, so we should merge 4827 first.Testing these changes
What to test
Who tested and where
jenkins retest
orjenkins multi-test
.