Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AN-385] new sam disk permissions #4828

Conversation

LizBaldo
Copy link
Collaborator

Jira ticket: https://broadworkbench.atlassian.net/browse/AN-385

Summary of changes

What

Why

Testing these changes

What to test

Who tested and where

  • This change is covered by automated tests
    • NB: Rerun automation tests on this PR by commenting jenkins retest or jenkins multi-test.
  • I validated this change
  • Primary reviewer validated this change
  • I validated this change in the dev environment

@LizBaldo LizBaldo requested a review from a team as a code owner February 14, 2025 14:49
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.57%. Comparing base (7e8b90d) to head (7c58ad6).
Report is 1 commits behind head on revert-4823-mtalbott-revert-listRuntimes.

Additional details and impacted files

Impacted file tree graph

@@                             Coverage Diff                              @@
##           revert-4823-mtalbott-revert-listRuntimes    #4828      +/-   ##
============================================================================
- Coverage                                     74.62%   74.57%   -0.05%     
============================================================================
  Files                                           166      166              
  Lines                                         14685    14609      -76     
  Branches                                       1164     1101      -63     
============================================================================
- Hits                                          10959    10895      -64     
+ Misses                                         3726     3714      -12     
Files with missing lines Coverage Δ
...ute/dsde/workbench/leonardo/dao/sam/SamUtils.scala 100.00% <100.00%> (ø)
...e/workbench/leonardo/db/DiskServiceDbQueries.scala 100.00% <100.00%> (ø)
...rkbench/leonardo/http/AppDependenciesBuilder.scala 97.87% <100.00%> (ø)
...bench/leonardo/http/AzureDependenciesBuilder.scala 97.14% <ø> (-0.16%) ⬇️
...rkbench/leonardo/http/GcpDependenciesBuilder.scala 73.14% <ø> (-0.31%) ⬇️
...ench/leonardo/http/service/DiskServiceInterp.scala 95.27% <100.00%> (+3.51%) ⬆️
...ch/leonardo/http/service/DiskV2ServiceInterp.scala 97.22% <100.00%> (+4.76%) ⬆️
...ch/leonardo/http/service/LeoAppServiceInterp.scala 87.34% <ø> (-0.04%) ⬇️
...workbench/leonardo/http/service/ProxyService.scala 73.55% <100.00%> (+0.12%) ⬆️
...rkbench/leonardo/http/service/RuntimeService.scala 100.00% <ø> (ø)
... and 2 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e8b90d...7c58ad6. Read the comment docs.

Copy link
Collaborator

@lucymcnatt lucymcnatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LizBaldo LizBaldo changed the base branch from develop to revert-4823-mtalbott-revert-listRuntimes February 19, 2025 16:22
@LizBaldo LizBaldo merged commit 431b9c3 into revert-4823-mtalbott-revert-listRuntimes Feb 19, 2025
23 checks passed
@LizBaldo LizBaldo deleted the AN-385-new-sam-disk-permissions branch February 19, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants