Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing metadata in a user profile without specifying a password brings up a success and an error panel #3818

Merged
merged 8 commits into from
Jan 28, 2025
Merged

Changing metadata in a user profile without specifying a password brings up a success and an error panel #3818

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6a2eac0
Merge pull request #3 from DSpace/dspace-8_x
VictorDuranEscire Aug 10, 2024
12ecca6
Merge branch 'DSpace:dspace-8_x' into dspace-8_x
VictorDuranEscire Jan 3, 2025
268e1f6
Agregar validador para mostrar mensaje de error solo si se escribe la…
VictorDuranEscire Jan 9, 2025
0362acc
Agregar validador para mostrar mensaje de error solo si se escribe la…
VictorDuranEscire Jan 9, 2025
0cbeab6
Merge remote-tracking branch 'origin/dspace-8_3641' into dspace-8_3641
VictorDuranEscire Jan 10, 2025
aaeb55b
Add validator to display error message only if current password is ty…
VictorDuranEscire Jan 10, 2025
ea5018b
Merge remote-tracking branch 'origin/dspace-8_3641' into dspace-8_3641
VictorDuranEscire Jan 10, 2025
ca8ba91
Set constant variable for valid current password in profile page
VictorDuranEscire Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/app/profile-page/profile-page.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,8 @@ export class ProfilePageComponent implements OnInit {
*/
updateSecurity() {
const passEntered = isNotEmpty(this.password);
if (this.invalidSecurity) {
const validCurrentPassword = isNotEmpty(this.currentPassword);
if (validCurrentPassword && !passEntered) {
this.notificationsService.error(this.translate.instant(this.PASSWORD_NOTIFICATIONS_PREFIX + 'error.general'));
}
if (!this.invalidSecurity && passEntered) {
Expand Down
Loading