Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing metadata in a user profile without specifying a password brings up a success and an error panel #3818

Merged
merged 8 commits into from
Jan 28, 2025

Conversation

VictorDuranEscire
Copy link
Contributor

Hi @tdonohue , I'm @jtimal partner, I like to share this PR with you:

References

Description

Add validator to display error message only if current password is typed in

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:
*I have added a validator on the profile page in the section to change the password to validate to show the error message only if the current password is typed and the new password is not.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug component: user profile 1 APPROVAL pull request only requires a single approval to merge port to main This PR needs to be ported to `main` branch for the next major release port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Jan 10, 2025
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @VictorDuranEscire ! I gave this a test today, and it fixes the bug. Password modification still seems to work, as does profile modification.

@tdonohue tdonohue added this to the 8.1 milestone Jan 28, 2025
@tdonohue tdonohue merged commit 47159fe into DSpace:dspace-8_x Jan 28, 2025
15 checks passed
@dspace-bot
Copy link
Contributor

Backport failed for main, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin main
git worktree add -d .worktree/backport-3818-to-main origin/main
cd .worktree/backport-3818-to-main
git switch --create backport-3818-to-main
git cherry-pick -x 268e1f695034caa570677417c96f8598b206ab0e 0362accf9d942e0c94c78eec40872ca1f72526f2 ca8ba9195d93ae95749879355fb12e7b66f1336b

@dspace-bot
Copy link
Contributor

Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-7_x
git worktree add -d .worktree/backport-3818-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-3818-to-dspace-7_x
git switch --create backport-3818-to-dspace-7_x
git cherry-pick -x 268e1f695034caa570677417c96f8598b206ab0e 0362accf9d942e0c94c78eec40872ca1f72526f2 ca8ba9195d93ae95749879355fb12e7b66f1336b

tdonohue pushed a commit to tdonohue/dspace-angular that referenced this pull request Jan 28, 2025
…ngs up a success and an error panel (DSpace#3818)

* Agregar validador para mostrar mensaje de error solo si se escribe la contraseña actual

* Agregar validador para mostrar mensaje de error solo si se escribe la contraseña actual

* Set constant variable for valid current password in profile page
tdonohue pushed a commit to tdonohue/dspace-angular that referenced this pull request Jan 28, 2025
…ngs up a success and an error panel (DSpace#3818)

* Agregar validador para mostrar mensaje de error solo si se escribe la contraseña actual

* Agregar validador para mostrar mensaje de error solo si se escribe la contraseña actual

* Set constant variable for valid current password in profile page
tdonohue pushed a commit to tdonohue/dspace-angular that referenced this pull request Jan 28, 2025
…ngs up a success and an error panel (DSpace#3818)

* Agregar validador para mostrar mensaje de error solo si se escribe la contraseña actual

* Agregar validador para mostrar mensaje de error solo si se escribe la contraseña actual

* Set constant variable for valid current password in profile page
@tdonohue tdonohue removed port to main This PR needs to be ported to `main` branch for the next major release port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug component: user profile
Projects
Development

Successfully merging this pull request may close these issues.

Changing metadata in a user profile without specifying a password brings up a success and an error panel
3 participants