-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing metadata in a user profile without specifying a password brings up a success and an error panel #3818
Conversation
Dspace 8 x
… contraseña actual
… contraseña actual
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks @VictorDuranEscire ! I gave this a test today, and it fixes the bug. Password modification still seems to work, as does profile modification.
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin main
git worktree add -d .worktree/backport-3818-to-main origin/main
cd .worktree/backport-3818-to-main
git switch --create backport-3818-to-main
git cherry-pick -x 268e1f695034caa570677417c96f8598b206ab0e 0362accf9d942e0c94c78eec40872ca1f72526f2 ca8ba9195d93ae95749879355fb12e7b66f1336b |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-7_x
git worktree add -d .worktree/backport-3818-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-3818-to-dspace-7_x
git switch --create backport-3818-to-dspace-7_x
git cherry-pick -x 268e1f695034caa570677417c96f8598b206ab0e 0362accf9d942e0c94c78eec40872ca1f72526f2 ca8ba9195d93ae95749879355fb12e7b66f1336b |
…ngs up a success and an error panel (DSpace#3818) * Agregar validador para mostrar mensaje de error solo si se escribe la contraseña actual * Agregar validador para mostrar mensaje de error solo si se escribe la contraseña actual * Set constant variable for valid current password in profile page
…ngs up a success and an error panel (DSpace#3818) * Agregar validador para mostrar mensaje de error solo si se escribe la contraseña actual * Agregar validador para mostrar mensaje de error solo si se escribe la contraseña actual * Set constant variable for valid current password in profile page
…ngs up a success and an error panel (DSpace#3818) * Agregar validador para mostrar mensaje de error solo si se escribe la contraseña actual * Agregar validador para mostrar mensaje de error solo si se escribe la contraseña actual * Set constant variable for valid current password in profile page
Hi @tdonohue , I'm @jtimal partner, I like to share this PR with you:
References
Description
Add validator to display error message only if current password is typed in
Instructions for Reviewers
Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.
List of changes in this PR:
*I have added a validator on the profile page in the section to change the password to validate to show the error message only if the current password is typed and the new password is not.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
main
branch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lint
npm run check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.