-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Arabic Translation #2863
Added Arabic Translation #2863
Conversation
@mohamedali654321 : It looks like this PR is currently failing "lint" (formatting) checks. You can see these locally by running |
@mohamedali654321: Could you also restore the comments in the json5 file, these are used to detect outdated translations. So your translation file should look like this: {
// "401.help": "You're not authorized to access this page. You can use the button below to get back to the home page.",
"401.help": "غير مصرح لك بالوصول إلى هذه الصفحة. يمكنك استخدام الزر أدناه للعودة إلى الصفحة الرئيسية.",
// "401.link.home-page": "Take me to the home page",
"401.link.home-page": "اذهب إلى الصفحة الرئيسية",
...
} |
Hey @mohamedali654321 because I realise that adding all those comments manually back in would have taken quite a while I created a script to fix your translation file. If you enable this option on your PR I think I can push the fix on your branch: git remote add alexandrevryghem https://github.com/alexandrevryghem/dspace-angular.git
git fetch alexandrevryghem fixed-ar-i18n-file
git push -fu origin alexandrevryghem/fixed-ar-i18n-file:main This new translation file also already contains all the other missing translations keys in addition. The only translation key I did not port was the one for
And these translations are also not included because they don't exist in the english file:"collection.page.browse.recent.head": "أحدث التقديمات", -> I removed this key in `en.json5` since it has been replaced with a search page so this is normal"collection.page.browse.recent.empty": "لا توجد مواد للعرض", -> I removed this key in `en.json5` since it has been replaced with a search page so this is normal"menu.section.notifications_reciter": "مطالبة المنشورات", "quality-assurance.button.detail": "عرض التفاصيل", "person.page.givenName": "الاسم الأول", "submission.sections.submit.progressbar.detect-duplicate": "التكرارات المحتملة", |
@alexandrevryghem Can you send the script because commenting on a translation line will take a lot of time? Also, the commands sent by you return with an error PS F:\ar-fix\dspace-angular-main> git push -fu origin alexandrevryghem/fixed-ar-i18n-file: main Please make sure you have the correct access rights |
@mohamedali654321 Try running the command |
@alexandrevryghem The steps have been followed and the comments have been added, thank you very much |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thank you @mohamedali654321 for your contribution! My apologies it has taken a while to get back to this PR. But, today I tested it out and found that the translation is working. Using Google Translate, I verified a few pages and they all look good. Thanks again.
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-7_x
git worktree add -d .worktree/backport-2863-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-2863-to-dspace-7_x
git switch --create backport-2863-to-dspace-7_x
git cherry-pick -x 159b0c29de1dcb9a2aff4c9f4ca663d05b573bf3 |
Added Arabic Translation
Added ar.json5 translation and modified config files to include this translation
List of changes in this PR:
Added Arabic translation
Updated config.example.yml