Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arabic Text Translations #973

Closed
wants to merge 2 commits into from
Closed

Arabic Text Translations #973

wants to merge 2 commits into from

Conversation

AdelHCI
Copy link

@AdelHCI AdelHCI commented Dec 14, 2020

References

Add references/links to any related issues or PRs. These may include:

  • Fixes #[issue-number]
  • Requires DSpace/DSpace#[pr-number] (if a REST API PR is required to test this)

Description

Translated some text to Arabic.

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

  • First, ...
  • Second, ...

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR doesn't introduce circular dependencies
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

Made some translations for arabic text.
@bram-atmire
Copy link
Member

Hi @AdelHCI, many thanks for contributing to the Arabic DSpace 7 translation! I was able to build and deploy your file locally, which is great. But many of the keys are currently still untranslated.

Are you planning to do more translation work? If so, I will leave your pull request open, and you can add further commits to it. If you can't continue the work, I might still merge "as-is" so that another translator can pick up the work.

Thanks again and apologies for the belated review !

@AdelHCI
Copy link
Author

AdelHCI commented Feb 4, 2021 via email

@bram-atmire bram-atmire added the i18n / l10n Internationalisation and localisation, related to message catalogs label Feb 4, 2021
@alexandrevryghem
Copy link
Member

Closing this because because a more complete Arabic translation file was already merged in #2863

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n / l10n Internationalisation and localisation, related to message catalogs merge conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants