#1692: do not error in build if git folder is not available #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der is not available
…actually used; a copy in the src folder is used instead
…(the VERSION file). This also allows us to print out the version in the banner, which is useful if not git info is available
nmm0
commented
Mar 3, 2022
|
|
||
| file(READ "VERSION" _vt_version_str) | ||
| string(STRIP "${_vt_version_str}" _vt_version_str) | ||
| project(vt VERSION ${_vt_version_str}) |
There was a problem hiding this comment.
Version number changes should only be done in the VERSION file now
nmm0
commented
Mar 3, 2022
| set(VERSION_PATCH "0") | ||
| set(VERSION_MAJOR "${PROJECT_VERSION_MAJOR}") | ||
| set(VERSION_MINOR "${PROJECT_VERSION_MINOR}") | ||
| set(VERSION_PATCH "${PROJECT_VERSION_PATCH}") |
There was a problem hiding this comment.
Not directly related to the PR but I thought I might as well do it with the versioning consistency, but these will now read from the cmake file
nmm0
commented
Mar 3, 2022
| fmt::print("{}{}{}", vt_pre, f6, reset); | ||
| fmt::print("{}{}{}", vt_pre, f7, reset); | ||
| auto vt_version_string = fmt::format("{}.{}.{}", vt_version_major, vt_version_minor, vt_version_patch); | ||
| std::array< std::string, 11 > info_lines = { |
There was a problem hiding this comment.
Made it easier to add lines to the banner. When we eventually switch to C++17, we won't need to give the number of lines to std::array, it will be able to use CTAD to deduce
nmm0
changed the title
lifflander
approved these changes
Mar 3, 2022
cz4rs
pushed a commit
that referenced
this pull request
Mar 4, 2022
#1692: do not error in build if git folder is not available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1692