Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1679: Create 1.1.1 beta v7 release candidate #1682

Merged
merged 56 commits into from
Mar 8, 2022
Merged

1679: Create 1.1.1 beta v7 release candidate #1682

merged 56 commits into from
Mar 8, 2022

Conversation

cz4rs
Copy link
Contributor

@cz4rs cz4rs commented Feb 21, 2022 •
edited
Loading

Jakub Strzebonski and others added 20 commits January 14, 2022 12:50
#1636 add API for temporarily enabling/disabling debug prints
db22225
#1636 document new functionality
e6d3e56
#1636 use theConfig instead of preConfigRef
9896d94
#1636 revert preConfigRef changes
5db473c
#1636 change preprocessor directives indenting setting
fd710cb
#1636 abort if vt is not yet initialized
75f6630
#1636 add missing include
c7379fd
@lifflander
Merge pull request #1658 from DARMA-tasking/1636-api-temporarily-enab…
b1e3867 
…ling-disabling-debug-prints

#1636 add API for temporarily enabling/disabling debug prints
@JacobDomagala
#1445: active: schedule messages on self-send
3575997
@JacobDomagala
#1445: active: Add LB stats instrumentation for self-send runnable ob…
a4ececd 
…ject
@lifflander
Merge pull request #1494 from DARMA-tasking/1445-schedule-msg-on-self…
c20e83c 
…-send

1445: active: schedule messages on self-send
#1667 remove features_enableif.h
0ba7993
#1667 clean up configs/types
f8f74d1
#1667 clean up configs/debug
26650ed
#1667 clean up configs/error
e4e188e
#1667 fix trace cmake
67a9e57
#1667 move preConfigRef() forward decleration back to debug_colorize.h
ffc9800
#1667 extract prettyPrintStack() to *.cc file
07f5d90
#1667 Move prettyPrintStack to stack_out
8d7ce4a
@PhilMiller
Merge pull request #1670 from DARMA-tasking/1667-config-includes-refa…
c7e7832 
…ctoring

#1667 refactor config includes
@github-actions
Copy link

github-actions bot commented Feb 21, 2022 •
edited
Loading

PR tests (gcc-5, ubuntu, mpich)

Build for 8bfefd2

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Feb 21, 2022 •
edited
Loading

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 8bfefd2

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Feb 21, 2022 •
edited
Loading

PR tests (gcc-6, ubuntu, mpich)

Build for 8bfefd2

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Feb 21, 2022 •
edited
Loading

PR tests (clang-3.9, ubuntu, mpich)

Build for 8bfefd2

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Feb 21, 2022 •
edited
Loading

PR tests (clang-5.0, ubuntu, mpich)

Build for 8bfefd2

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Feb 21, 2022 •
edited
Loading

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 8bfefd2

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Feb 21, 2022 •
edited
Loading

PR tests (clang-9, ubuntu, mpich)

Build for 8bfefd2

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Feb 21, 2022 •
edited
Loading

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for 8bfefd2

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Feb 21, 2022 •
edited
Loading

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for 8bfefd2

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Feb 21, 2022 •
edited
Loading

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 8bfefd2

Compilation - successful

Testing - passed

Build log

nmm0 and others added 25 commits March 4, 2022 18:15
@nmm0 @cz4rs
#1677: cmake: set a secondary variable for refspec files so it can be…
2e6d4c2 
… empty if not on a named branch
@nmm0 @cz4rs
#1677: cmake: clean up old git revision scripts
93ad318
@nmm0 @cz4rs
#1677: cmake: only depend on packed refs file if it exists
2e9f85f
@nmm0 @cz4rs
#1677: cmake: don't silence git command errors
046bf6d
@nmm0 @cz4rs
#1677: cmake: use the parent directory of the .git folder to locate t…
8903884 
…he git repository directory
@nmm0 @cz4rs
#1677: cmake: set dependency on entire .git folder
6daf3ff
@nmm0 @cz4rs
#1677: cmake: get git folder using git rev-parse and similarly for th…
40ea610 
…e current sha1
@cz4rs
#1550 allow users to pass AppConfig to vt during init
b5c084a
@cz4rs
#1550 fix parameter type
068808e
@cz4rs
#1550 fix runtime init
ab6d241
@cz4rs
#1550 print predefined options overwritten by CLI arguments
489ddff
@cz4rs
#1550 clean up ArgConfig struct
f90ddfe
@nmm0 @cz4rs
#1677: cmake: fix newline EOF
dc177bd
@cz4rs
#1550 move comment to suitable place
f628a7d
@PhilMiller @cz4rs
Merge pull request #1683 from DARMA-tasking/1677-dont-rerun-cmake-for…
6443e93 
…-git-ref

1677: dont rerun cmake for git ref
@cz4rs
#1550 fix gcc10 unit tests failures
0dd4a65
@cz4rs
#1550 fix typo in comment
c3c25d7
@cz4rs
#1550 add documentation
808a149
@cz4rs
#1550 document command line arguments processing precedence
5464427
@cz4rs
#1550 document and test order of parsing arguments passed from cli, f…
1408cc0 
…ile and appConfig
@nmm0 @cz4rs
#1692: make build script not error out when running cmake if .git fol…
0b74ed1 
…der is not available
@nlslatt @cz4rs
Merge pull request #1674 from DARMA-tasking/1550-allow-passing-appcon…
a2eb852 
…fig-to-vt-during-init

#1550 allow passing appconfig to vt during init
@nmm0 @cz4rs
#1692: remove vt_git_revision.h from root directory because it's not …
ae489a2 
…actually used; a copy in the src folder is used instead
@nmm0 @cz4rs
#1692: cmake: make version consistent and only modified in one place …
2ff27b9 
…(the VERSION file). This also allows us to print out the version in the banner, which is useful if not git info is available
@lifflander @cz4rs
Merge pull request #1693 from DARMA-tasking/1692-dont-error-with-no-git
8bfefd2 
#1692: do not error in build if git folder is not available
@cz4rs cz4rs force-pushed the 1679-release-1-1-1-beta-7 branch from 9807d16 to 8bfefd2 Compare March 4, 2022 17:15
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #1682 (8bfefd2) into main (176190c) will increase coverage by 0.12%.
The diff coverage is 92.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1682      +/-   ##
==========================================
+ Coverage   83.53%   83.65%   +0.12%     
==========================================
  Files         797      798       +1     
  Lines       30816    31167     +351     
==========================================
+ Hits        25741    26074     +333     
- Misses       5075     5093      +18
Impacted Files Coverage Δ
src/vt/collective/reduce/scoping/strong_types.h 100.00% <ø> (ø)
src/vt/configs/arguments/args.h 100.00% <ø> (ø)
src/vt/configs/debug/debug_print.h 100.00% <ø> (ø)
src/vt/configs/debug/debug_var_unused.h 100.00% <ø> (ø)
src/vt/configs/error/error.impl.h 100.00% <ø> (ø)
src/vt/configs/error/soft_error.h 90.00% <ø> (ø)
src/vt/runtime/runtime.h 100.00% <ø> (ø)
src/vt/termination/termination.h 100.00% <ø> (ø)
src/vt/trace/trace_lite.h 100.00% <ø> (ø)
src/vt/utils/strong/strong_type.h 100.00% <ø> (ø)
... and 29 more

lifflander
lifflander approved these changes Mar 8, 2022
View reviewed changes
Copy link
Collaborator

@lifflander lifflander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@nmm0 nmm0 merged commit 5a1d322 into main Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lifflander lifflander lifflander approved these changes

@nlslatt nlslatt nlslatt approved these changes

@JacobDomagala JacobDomagala Awaiting requested review from JacobDomagala

@jstrzebonski jstrzebonski Awaiting requested review from jstrzebonski

@nmm0 nmm0 Awaiting requested review from nmm0

@PhilMiller PhilMiller Awaiting requested review from PhilMiller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create 1.1.1 beta v7 release candidate
6 participants
@cz4rs @nlslatt @lifflander @nmm0 @JacobDomagala @PhilMiller