Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/vite #206

Merged
merged 15 commits into from
Feb 25, 2025
Merged

Feature/vite #206

merged 15 commits into from
Feb 25, 2025

Conversation

CourtneyGosselin
Copy link
Member

@CourtneyGosselin CourtneyGosselin commented Feb 5, 2025

Ticket(s)

Switch to Vite DIG-1610

Description

This PR migrates the project from react-scripts to Vite, as react-scripts is now deprecated.

Expected Behaviour

The portal should function as before, with improved build performance and faster development reloads

Associated PRs:

CanDIGv2 PR

Types of Change(s)

  • 🪲 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)

Has it been tested for:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • Prettier linter doesn't return errors
  • Production branch PR browser testing: Chrome, Firefox, Edge, etc.
  • Locally tested
  • Dev server tested
  • Production tested when merging into stable/production branch
  • Runbook tasks pass locally/on UHN-Dev
  • If visuals have changed, Runbook has been updated with new screenshots

CourtneyGosselin and others added 14 commits January 27, 2025 15:24
Signed-off-by: Courtney Gosselin <courtney@gosselin.io>
Signed-off-by: Courtney Gosselin <courtney@gosselin.io>
Signed-off-by: Courtney Gosselin <courtney@gosselin.io>
Signed-off-by: Courtney Gosselin <courtney@gosselin.io>
Signed-off-by: Courtney Gosselin <courtney@gosselin.io>
Signed-off-by: Courtney Gosselin <courtney@gosselin.io>
Signed-off-by: Courtney Gosselin <courtney@gosselin.io>
Signed-off-by: Courtney Gosselin <courtney@gosselin.io>
Signed-off-by: Courtney Gosselin <courtney@gosselin.io>
Signed-off-by: Courtney Gosselin <courtney@gosselin.io>
Signed-off-by: Courtney Gosselin <courtney@gosselin.io>
Signed-off-by: Courtney Gosselin <courtney@gosselin.io>
Copy link
Contributor

@OrdiNeu OrdiNeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me when including the changes from here: CanDIG/CanDIGv2#975

@CourtneyGosselin CourtneyGosselin merged commit f1abb60 into develop Feb 25, 2025
3 checks passed
@CourtneyGosselin CourtneyGosselin deleted the feature/vite branch February 25, 2025 21:22
@CourtneyGosselin CourtneyGosselin restored the feature/vite branch February 26, 2025 18:43
CourtneyGosselin added a commit that referenced this pull request Feb 26, 2025
CourtneyGosselin added a commit that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants