-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{CI} Update Azure Pipelines to use Ubuntu 22.04 pools #30996
Open
wangzelin007
wants to merge
3
commits into
Azure:dev
Choose a base branch
from
wangzelin007:wzl/drop-ubuntu-2004-ado
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+12
−8
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
variables: | ||
ubuntu_pool: 'pool-ubuntu-2004' | ||
ubuntu_multi_core_pool: 'pool-ubuntu-2004-multi-core' | ||
ubuntu_pool: 'pool-ubuntu-2204' | ||
ubuntu_multi_core_pool: 'pool-ubuntu-latest-multi-core' | ||
windows_pool: 'pool-windows-2019' | ||
ubuntu_arm64_pool: 'ubuntu-arm64-2004-pool' | ||
ubuntu_arm64_pool: 'pool-ubuntu-latest-arm64' | ||
macos_pool: 'macOS-14' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,10 +27,10 @@ parameters: | |
default: | ||
- name: AMD64 | ||
value: amd64 | ||
pool: pool-ubuntu-2004-multi-core | ||
pool: pool-ubuntu-latest-multi-core | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Haha, that's why I don't use variable here previously. |
||
- name: ARM64 | ||
value: arm64 | ||
pool: ubuntu-arm64-2004-pool | ||
pool: pool-ubuntu-latest-arm64 | ||
|
||
jobs: | ||
- job: CheckPullRequest | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for not using
pool-ubuntu-latest
is that Azure PowerShell team has already createdpool-ubuntu-2204
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the ubuntu version in
pool-ubuntu-latest-multi-core
, 22.04 or 24.04?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
22.04,because 2204 is the latest one in 1ES image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a pretty old image. I prefer to change the PR title to 22.04 instead of
latest
.In general,
latest
should refer to 24.04, which was released 1 year ago.