-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{CI} Update Azure Pipelines to use Ubuntu 22.04 pools #30996
base: dev
Are you sure you want to change the base?
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
@@ -1,6 +1,6 @@ | |||
variables: | |||
ubuntu_pool: 'pool-ubuntu-2004' | |||
ubuntu_multi_core_pool: 'pool-ubuntu-2004-multi-core' | |||
ubuntu_pool: 'pool-ubuntu-2204' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for not using pool-ubuntu-latest
is that Azure PowerShell team has already created pool-ubuntu-2204
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the ubuntu version in pool-ubuntu-latest-multi-core
, 22.04 or 24.04?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
22.04,because 2204 is the latest one in 1ES image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a pretty old image. I prefer to change the PR title to 22.04 instead of latest
.
In general, latest
should refer to 24.04, which was released 1 year ago.
3d1957c
to
47ed94f
Compare
@@ -27,10 +27,10 @@ parameters: | |||
default: | |||
- name: AMD64 | |||
value: amd64 | |||
pool: pool-ubuntu-2004-multi-core | |||
pool: pool-ubuntu-latest-multi-core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, that's why I don't use variable here previously.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a
: Make some customer-facing breaking change[Component Name 2]
az command b
: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.