-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{CI} Refactor git hooks to improve cross-platform compatibility #30882
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,24 @@ | ||
#!/usr/bin/env sh | ||
":" //; if command -v pwsh >/dev/null 2>&1; then pwsh -ExecutionPolicy Bypass -File .githooks/pre-commit.ps1; else sh .githooks/pre-commit.sh; fi; exit $? # Try PowerShell Core first, then sh on Unix | ||
":" //; exit # Skip rest on Unix | ||
|
||
@echo off | ||
powershell -NoProfile -Command "if (Get-Command powershell -ErrorAction SilentlyContinue) { exit 0 } else { exit 1 }" | ||
if %errorlevel% equ 0 ( | ||
powershell -ExecutionPolicy Bypass -File .githooks\pre-commit.ps1 | ||
) else ( | ||
echo Error: PowerShell is not available. Please install PowerShell. | ||
exit /b 1 | ||
) | ||
exit /b %errorlevel% | ||
# Check if running in Windows | ||
if [ -n "$COMSPEC" ]; then | ||
# Windows section - Execute directly with PowerShell | ||
powershell -NoProfile -Command " | ||
if (Get-Command powershell -ErrorAction SilentlyContinue) { | ||
Write-Host 'PowerShell found, executing pre-commit.ps1...' | ||
powershell -ExecutionPolicy Bypass -File '.githooks\pre-commit.ps1' | ||
exit $LASTEXITCODE | ||
} else { | ||
Write-Host 'Error: PowerShell is not available. Please install PowerShell.' | ||
exit 1 | ||
} | ||
" | ||
echo "Exiting with status $?" | ||
exit $? | ||
else | ||
# Unix-like system section | ||
echo "Unix-like system found, executing pre-commit.sh..." | ||
sh .githooks/pre-commit.sh | ||
echo "Exiting with status $?" | ||
exit $? | ||
fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,24 @@ | ||
#!/usr/bin/env sh | ||
":" //; if command -v pwsh >/dev/null 2>&1; then pwsh -ExecutionPolicy Bypass -File .githooks/pre-push.ps1; else sh .githooks/pre-push.sh; fi; exit $? # Try PowerShell Core first, then sh on Unix | ||
":" //; exit # Skip rest on Unix | ||
|
||
@echo off | ||
powershell -NoProfile -Command "if (Get-Command powershell -ErrorAction SilentlyContinue) { exit 0 } else { exit 1 }" | ||
if %errorlevel% equ 0 ( | ||
powershell -ExecutionPolicy Bypass -File .githooks\pre-push.ps1 | ||
) else ( | ||
echo Error: PowerShell is not available. Please install PowerShell. | ||
exit /b 1 | ||
) | ||
exit /b %errorlevel% | ||
# Check if running in Windows | ||
if [ -n "$COMSPEC" ]; then | ||
# Windows section - Execute directly with PowerShell | ||
powershell -NoProfile -Command " | ||
if (Get-Command powershell -ErrorAction SilentlyContinue) { | ||
Write-Host 'PowerShell found, executing pre-push.ps1...' | ||
powershell -ExecutionPolicy Bypass -File '.githooks\pre-push.ps1' | ||
exit $LASTEXITCODE | ||
} else { | ||
Write-Host 'Error: PowerShell is not available. Please install PowerShell.' | ||
exit 1 | ||
} | ||
" | ||
echo "Exiting with status $?" | ||
exit $? | ||
else | ||
# Unix-like system section | ||
echo "Unix-like system found, executing pre-push.sh..." | ||
sh .githooks/pre-push.sh | ||
echo "Exiting with status $?" | ||
exit $? | ||
fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,8 +45,10 @@ if ($mergeBase -ne $upstreamHead) { | |
Write-Host "Would you like to automatically rebase and setup? [Y/n]" -ForegroundColor Yellow | ||
|
||
try { | ||
$reader = [System.IO.StreamReader]::new("CON") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
$input = $reader.ReadLine() | ||
$input = Read-Host | ||
if ([string]::IsNullOrEmpty($input)) { | ||
$input = "Y" | ||
} | ||
} catch { | ||
Write-Host "Error reading input. Aborting push..." -ForegroundColor Red | ||
exit 1 | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it "specifies" the command interpreter, which by default is cmd.exe in Windows