{CI} Refactor git hooks to improve cross-platform compatibility #30882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update pre-commit and pre-push hooks to support both Windows and Unix-like systems.
Update pre-push PowerShell script to use Read-Host for input and provide a default 'Y' response when no input is given
️✔️AzureCLI-FullTest
|
|
Hi @wangzelin007, |
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
yonzhan,
jiasli,
jsntcy,
bebound and
Pan-Qi
wangzelin007
commented
Feb 25, 2025
| @@ -45,8 +45,10 @@ if ($mergeBase -ne $upstreamHead) { | |||
| Write-Host "Would you like to automatically rebase and setup? [Y/n]" -ForegroundColor Yellow | |||
|
|
|||
| try { | |||
| $reader = [System.IO.StreamReader]::new("CON") | |||
There was a problem hiding this comment.
CON relies on the .NET framework, so replace it with the more generic Read-Host
wangzelin007
commented
Feb 25, 2025
| ) | ||
| exit /b %errorlevel% | ||
| # Check if running in Windows | ||
| if [ -n "$COMSPEC" ]; then |
There was a problem hiding this comment.
it "specifies" the command interpreter, which by default is cmd.exe in Windows
kairu-ms
approved these changes
Feb 25, 2025
CustardTart32
pushed a commit
to CustardTart32/azure-cli
that referenced
this pull request
Feb 27, 2025
…e#30882) * {CI} Refactor git hooks to improve cross-platform compatibility Update pre-commit and pre-push hooks to support both Windows and Unix-like systems. * {CI} Improve input handling in pre-push git hook Update pre-push PowerShell script to use Read-Host for input and provide a default 'Y' response when no input is given
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update pre-commit and pre-push hooks to support both Windows and Unix-like systems.Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.